You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/11/01 11:20:26 UTC

[GitHub] [hudi] slfan1989 opened a new pull request, #7107: HUDI-5124. Fix HoodieInternalRowFileWriter#canWrite error return tag.

slfan1989 opened a new pull request, #7107:
URL: https://github.com/apache/hudi/pull/7107

   ### Change Logs
   
   When reading the code, I found that the `return` tag of the `canWrite` method of the `HoodieInternalRowFileWriter` of hudi-spark-client is inaccurate. I searched globally at the `hudi-client` module level, only this one has a problem, submit pr to fix.
   
   ### Impact
   
   none
   
   ### Risk level (write none, low medium or high below)
   
   none
   
   ### Documentation Update
   
   none
   ### Contributor's checklist
   
   - [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
   - [ ] Change Logs and Impact were stated clearly
   - [ ] Adequate tests were added if applicable
   - [ ] CI passed
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] slfan1989 commented on pull request #7107: [HUDI-5124]. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
slfan1989 commented on PR #7107:
URL: https://github.com/apache/hudi/pull/7107#issuecomment-1299461904

   @xushiyan Can you help review this pr? Thank you very much!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7107: HUDI-5124. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7107:
URL: https://github.com/apache/hudi/pull/7107#issuecomment-1298421156

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "status" : "UNKNOWN",
       "url" : "TBD",
       "triggerID" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d93e4e05434508196af898879d11ef9b23b33ba3 UNKNOWN
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] danny0405 merged pull request #7107: [HUDI-5124]. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #7107:
URL: https://github.com/apache/hudi/pull/7107


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7107: HUDI-5124. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7107:
URL: https://github.com/apache/hudi/pull/7107#issuecomment-1298427249

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "status" : "PENDING",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12707",
       "triggerID" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d93e4e05434508196af898879d11ef9b23b33ba3 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12707) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] xushiyan commented on pull request #7107: [HUDI-5124]. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
xushiyan commented on PR #7107:
URL: https://github.com/apache/hudi/pull/7107#issuecomment-1300155130

   @slfan1989 please simply create a `[MINOR]` PR instead of creating JIRA this kind of change. thanks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] hudi-bot commented on pull request #7107: HUDI-5124. Fix HoodieInternalRowFileWriter#canWrite error return tag.

Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #7107:
URL: https://github.com/apache/hudi/pull/7107#issuecomment-1298612255

   <!--
   Meta data
   {
     "version" : 1,
     "metaDataEntries" : [ {
       "hash" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "status" : "SUCCESS",
       "url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12707",
       "triggerID" : "d93e4e05434508196af898879d11ef9b23b33ba3",
       "triggerType" : "PUSH"
     } ]
   }-->
   ## CI report:
   
   * d93e4e05434508196af898879d11ef9b23b33ba3 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=12707) 
   
   <details>
   <summary>Bot commands</summary>
     @hudi-bot supports the following commands:
   
    - `@hudi-bot run azure` re-run the last Azure build
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org