You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/04/18 18:13:36 UTC

[GitHub] [arrow-datafusion] wangxiaoying opened a new issue, #2265: Support "IS NOT TRUE/FALSE" syntax

wangxiaoying opened a new issue, #2265:
URL: https://github.com/apache/arrow-datafusion/issues/2265

   **Is your feature request related to a problem or challenge? Please describe what you are trying to do.**
   
   Currently when the sql query contains `is not true/false`, the following error will be thrown:
   ```
   thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: SQL(ParserError("Expected [NOT] NULL or [NOT] DISTINCT FROM after IS, found: NOT"))'
   ```
   
   **Describe the solution you'd like**
   `col is not true(false)` should have the same result with `col is NULL or col = false(true)`. For example in postgres, it works like follow:
   <img width="720" alt="image" src="https://user-images.githubusercontent.com/5569610/163853092-79e660d7-13d6-4bff-801f-cc83034ab577.png">
   
   
   **Describe alternatives you've considered**
   A clear and concise description of any alternative solutions or features you've considered.
   
   **Additional context**
   It looks like the error happens when parsing the query at [here](https://github.com/sqlparser-rs/sqlparser-rs/blob/main/src/parser.rs#L1116). Might need to support this syntax in `sqlparser` first.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] sarahyurick commented on issue #2265: Support "IS NOT TRUE/FALSE" syntax

Posted by GitBox <gi...@apache.org>.
sarahyurick commented on issue #2265:
URL: https://github.com/apache/arrow-datafusion/issues/2265#issuecomment-1224459608

   @alamb do you think there's a quick solution (like #3235) for this case as well? Or should the implementation look similar to #3189?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] sarahyurick commented on issue #2265: Support "IS NOT TRUE/FALSE" syntax

Posted by GitBox <gi...@apache.org>.
sarahyurick commented on issue #2265:
URL: https://github.com/apache/arrow-datafusion/issues/2265#issuecomment-1219796696

   "IS NOT TRUE/FALSE" should be possible now that https://github.com/sqlparser-rs/sqlparser-rs/pull/583 has been merged. I can start working on this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] sarahyurick commented on issue #2265: Support "IS NOT TRUE/FALSE" syntax

Posted by GitBox <gi...@apache.org>.
sarahyurick commented on issue #2265:
URL: https://github.com/apache/arrow-datafusion/issues/2265#issuecomment-1224961037

   Mostly asking because if it's the latter, I could edit #3189 to be for "IS NOT TRUE/FALSE" instead. Otherwise, I'll close that PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow-datafusion] andygrove closed issue #2265: Support "IS NOT TRUE/FALSE" syntax

Posted by GitBox <gi...@apache.org>.
andygrove closed issue #2265: Support "IS NOT TRUE/FALSE" syntax
URL: https://github.com/apache/arrow-datafusion/issues/2265


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org