You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by "wangxianghu (Jira)" <ji...@apache.org> on 2020/06/30 15:17:00 UTC

[jira] [Updated] (HUDI-1062) Remove unnecessary maxEvent check and add some log in KafkaOffsetGen

     [ https://issues.apache.org/jira/browse/HUDI-1062?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

wangxianghu updated HUDI-1062:
------------------------------
    Summary: Remove unnecessary maxEvent check and add some log in KafkaOffsetGen  (was: Remove unnecessary maxEvent check in KafkaOffsetGen)

> Remove unnecessary maxEvent check and add some log in KafkaOffsetGen
> --------------------------------------------------------------------
>
>                 Key: HUDI-1062
>                 URL: https://issues.apache.org/jira/browse/HUDI-1062
>             Project: Apache Hudi
>          Issue Type: Task
>          Components: Code Cleanup
>            Reporter: wangxianghu
>            Assignee: Trevorzhang
>            Priority: Minor
>
> {code:java}
> //code
> maxEventsToReadFromKafka = (maxEventsToReadFromKafka == Long.MAX_VALUE || maxEventsToReadFromKafka == Integer.MAX_VALUE)
>     ? Config.maxEventsFromKafkaSource : maxEventsToReadFromKafka;
> {code}
> this line is unnecessary, we‘d better remove it.
> besides, when the source limit is not configured, it will take *maxEventsToReadFromKafka*(50M) as the default value, we can give a log to notify the user.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)