You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/15 02:03:57 UTC
[GitHub] [spark] ulysses-you opened a new pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
ulysses-you opened a new pull request #30772:
URL: https://github.com/apache/spark/pull/30772
backport for branch-2.4.
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
The deterministic field is wider than `NonDerterministic`, we should keep same range between pull out and check analysis.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For example
```
select * from values(1), (4) as t(c1) order by java_method('java.lang.Math', 'abs', c1)
```
We will get exception since `java_method` deterministic field is false but not a `NonDeterministic`
```
Exception in thread "main" org.apache.spark.sql.AnalysisException: nondeterministic expressions are only allowed in
Project, Filter, Aggregate or Window, found:
java_method('java.lang.Math', 'abs', t.`c1`) ASC NULLS FIRST
in operator Sort [java_method(java.lang.Math, abs, c1#1) ASC NULLS FIRST], true
;;
```
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745003616
**[Test build #132787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132787/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747208177
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745161061
**[Test build #132821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132821/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745003616
**[Test build #132787 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132787/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745074417
**[Test build #132804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132804/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745173376
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37423/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745024617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132795/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745024607
**[Test build #132795 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132795/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745152548
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132804/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #30772:
URL: https://github.com/apache/spark/pull/30772
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745083026
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37406/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747217919
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747289670
**[Test build #132931 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132931/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745007251
**[Test build #132787 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132787/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
* This patch **fails to build**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745098160
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37406/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745184816
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37423/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745181569
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37423/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745098160
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37406/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747293070
cc @maropu @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747231845
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745245994
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745090475
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37406/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745074417
**[Test build #132804 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132804/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745245994
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132821/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747179945
The jenkins test failed with
```
======================================================================
ERROR: test_complex_groupby (pyspark.sql.tests.GroupedMapPandasUDFTests)
----------------------------------------------------------------------
Traceback (most recent call last):
File "/home/jenkins/workspace/SparkPullRequestBuilder@2/python/pyspark/sql/tests.py", line 5765, in test_complex_groupby
expected = expected.sort_values(['id', 'v']).reset_index(drop=True)
File "/home/jenkins/anaconda2/lib/python2.7/site-packages/pandas/core/frame.py", line 4711, in sort_values
for x in by]
File "/home/jenkins/anaconda2/lib/python2.7/site-packages/pandas/core/generic.py", line 1701, in _get_label_or_level_values
self._check_label_or_level_ambiguity(key, axis=axis)
File "/home/jenkins/anaconda2/lib/python2.7/site-packages/pandas/core/generic.py", line 1655, in _check_label_or_level_ambiguity
raise ValueError(msg)
ValueError: 'id' is both an index level and a column label, which is ambiguous.
```
github action skipped and passed
```
test_array_type_correct (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_coerce (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_column_order (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_complex_groupby (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_datatype_string (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
```
This failed test is pandas related and it passed with branch-3.0 and higer. I'm not familiar with this part, @HyukjinKwon do you have any idea ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745022276
**[Test build #132795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132795/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745011419
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745160031
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747298086
thanks, merging to 2.4!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745152548
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132804/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747210119
**[Test build #132931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132931/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745184816
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37423/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745007281
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132787/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] ulysses-you commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747294097
Seems the jenkins build env is different if the machine is different ? The last passed test also skip the pandas test
```
test_coerce (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_column_order (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_complex_groupby (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_datatype_string (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_decorator (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
test_empty_groupby (pyspark.sql.tests.GroupedMapPandasUDFTests) ... skipped 'Pandas >= 0.19.2 must be installed; however, it was not found.'
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745007281
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745239356
**[Test build #132821 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132821/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745022276
**[Test build #132795 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132795/testReport)** for PR 30772 at commit [`1e240e8`](https://github.com/apache/spark/commit/1e240e8ec982d6b55229f89b23f861d9c81007fe).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745161061
**[Test build #132821 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132821/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745023794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37397/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747290256
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132931/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745008362
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37395/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747210119
**[Test build #132931 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132931/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745023794
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37397/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745140012
**[Test build #132804 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132804/testReport)** for PR 30772 at commit [`cf4a7bb`](https://github.com/apache/spark/commit/cf4a7bbb75a913c73e40de291eca76eea73dd07e).
* This patch **fails PySpark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-745024617
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132795/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30772: [SPARK-33733][SQL][2.4] PullOutNondeterministic should check and collect deterministic field
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30772:
URL: https://github.com/apache/spark/pull/30772#issuecomment-747231845
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37534/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org