You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Kishan Kavala <Ki...@citrix.com> on 2013/05/24 10:12:43 UTC

Review Request: Config value has to be encrypted for Hidden category configs

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11369/
-----------------------------------------------------------

Review request for cloudstack and Chip Childers.


Description
-------

As part of the fix for CLOUDSTACK-528, category of few configs is changed to 'Hidden'. Hidded config vales are expected to be encrypted. So, the value has to be encrypted before changing the category


This addresses bug CLOUDSTACK-528.


Diffs
-----

  server/src/com/cloud/upgrade/dao/Upgrade302to40.java ecda872 
  setup/db/db/schema-302to40.sql 7fa7348 

Diff: https://reviews.apache.org/r/11369/diff/


Testing
-------

Tested upgrade from 302 and executed unit tests


Thanks,

Kishan Kavala


Re: Review Request: Config value has to be encrypted for Hidden category configs

Posted by Chip Childers <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11369/#review21092
-----------------------------------------------------------

Ship it!


committed to 4.1 as a65c36a39138308f95049a815fa99f4da0bbde1a

Please make sure this is in master

- Chip Childers


On May 24, 2013, 8:12 a.m., Kishan Kavala wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11369/
> -----------------------------------------------------------
> 
> (Updated May 24, 2013, 8:12 a.m.)
> 
> 
> Review request for cloudstack and Chip Childers.
> 
> 
> Description
> -------
> 
> As part of the fix for CLOUDSTACK-528, category of few configs is changed to 'Hidden'. Hidded config vales are expected to be encrypted. So, the value has to be encrypted before changing the category
> 
> 
> This addresses bug CLOUDSTACK-528.
> 
> 
> Diffs
> -----
> 
>   server/src/com/cloud/upgrade/dao/Upgrade302to40.java ecda872 
>   setup/db/db/schema-302to40.sql 7fa7348 
> 
> Diff: https://reviews.apache.org/r/11369/diff/
> 
> 
> Testing
> -------
> 
> Tested upgrade from 302 and executed unit tests
> 
> 
> Thanks,
> 
> Kishan Kavala
> 
>