You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Andrei Dulvac <an...@gmail.com> on 2016/05/02 12:10:50 UTC
Re: Splitting up sling-testing-tools
Hey,
I created SLING-5706 with a patch that has a concise README.md with
examples, which I hope are clear enough to kickstart using the tools.
Could you guys have a look and if it is ok, apply it?
I don't know how else to provide this patch - I think the stuff that goes
to cms.apache.org is only reachable by commiters.
Thanks a lot,
- Andrei
On Fri, Apr 29, 2016 at 5:35 PM Konrad Windszus <ko...@gmx.de> wrote:
> Thanks for that, looks great. Can we have an updated documentation at
> https://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html,
>
> https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html
> and
> https://sling.apache.org/documentation/development/sling-testing-tools.html
> briefly describing the new structure?
>
> Thanks,
> Konrad
> > On 29 Apr 2016, at 16:32, Bertrand Delacretaz <bd...@apache.org>
> wrote:
> >
> > Hi Andrei,
> >
> > On Fri, Apr 29, 2016 at 3:43 PM, Andrei Dulvac <an...@gmail.com>
> wrote:
> >> ...You can find the PR at: https://github.com/apache/sling/pull/136
> >> JIRA issue: https://issues.apache.org/jira/browse/SLING-5703...
> >
> > Thanks, I've committed this!
> >
> > And created SLING-5704 for the eventual move of testing/tools to contrib.
> >
> > -Bertrand
>
>
Re: Splitting up sling-testing-tools
Posted by Andrei Dulvac <an...@gmail.com>.
Hi Konrad,
Absolutely these should be merged and the plan is to remove the
sling-testing-tools dep altogether. I will take a look.
- Andrei
On Thu, May 12, 2016 at 3:01 PM Konrad Windszus <ko...@gmx.de> wrote:
> I also just observed that the WebconsoleClient still has a dependency
> towards testing.tools.
> I created a bug report in https://issues.apache.org/jira/browse/SLING-5725
> <https://issues.apache.org/jira/browse/SLING-5725>.
>
> > On 12 May 2016, at 14:14, Konrad Windszus <ko...@gmx.de> wrote:
> >
> > Just had a closer look at those classes and to me the difference between
> WebconsoleClient and OsgiConsoleClient is not really obvious.
> > Shouldn't we rather merge those two?
> > Konrad
> >
> >> On 04 May 2016, at 14:47, Andrei Dulvac <an...@gmail.com>
> wrote:
> >>
> >> Hi,
> >>
> >> Thanks Radu for applying the docu patch.
> >> You can find a small section here:
> >>
> http://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html#http-based-integration-tests
> >>
> >> Cheers,
> >> - Andrei
> >>
> >> On Tue, May 3, 2016 at 11:54 AM Andrei Dulvac <an...@gmail.com>
> >> wrote:
> >>
> >>> Hi guys,
> >>>
> >>> Thanks for the explanations. I've added a section in the sling testing
> >>> page.
> >>> Please see the mail "CMS diff: Testing Sling-based applications" on the
> >>> dev list.
> >>> Could someone have a look?
> >>>
> >>> Thanks!
> >>> - Andrei
> >>>
> >>> On Tue, May 3, 2016 at 10:53 AM Bertrand Delacretaz <
> >>> bdelacretaz@apache.org> wrote:
> >>>
> >>>> On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de>
> wrote:
> >>>>> Just providing a patch on the markdown pages in the SVN referenced in
> >>>> [0] should work fine...
> >>>>
> >>>> Sure - where cms.apache.org can help is in previewing the changes
> with
> >>>> the exact same markdown engine used for sling.apache.org.
> >>>>
> >>>> -Bertrand
> >>>>
> >>>
> >
>
>
Re: Splitting up sling-testing-tools
Posted by Konrad Windszus <ko...@gmx.de>.
I also just observed that the WebconsoleClient still has a dependency towards testing.tools.
I created a bug report in https://issues.apache.org/jira/browse/SLING-5725 <https://issues.apache.org/jira/browse/SLING-5725>.
> On 12 May 2016, at 14:14, Konrad Windszus <ko...@gmx.de> wrote:
>
> Just had a closer look at those classes and to me the difference between WebconsoleClient and OsgiConsoleClient is not really obvious.
> Shouldn't we rather merge those two?
> Konrad
>
>> On 04 May 2016, at 14:47, Andrei Dulvac <an...@gmail.com> wrote:
>>
>> Hi,
>>
>> Thanks Radu for applying the docu patch.
>> You can find a small section here:
>> http://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html#http-based-integration-tests
>>
>> Cheers,
>> - Andrei
>>
>> On Tue, May 3, 2016 at 11:54 AM Andrei Dulvac <an...@gmail.com>
>> wrote:
>>
>>> Hi guys,
>>>
>>> Thanks for the explanations. I've added a section in the sling testing
>>> page.
>>> Please see the mail "CMS diff: Testing Sling-based applications" on the
>>> dev list.
>>> Could someone have a look?
>>>
>>> Thanks!
>>> - Andrei
>>>
>>> On Tue, May 3, 2016 at 10:53 AM Bertrand Delacretaz <
>>> bdelacretaz@apache.org> wrote:
>>>
>>>> On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de> wrote:
>>>>> Just providing a patch on the markdown pages in the SVN referenced in
>>>> [0] should work fine...
>>>>
>>>> Sure - where cms.apache.org can help is in previewing the changes with
>>>> the exact same markdown engine used for sling.apache.org.
>>>>
>>>> -Bertrand
>>>>
>>>
>
Re: Splitting up sling-testing-tools
Posted by Konrad Windszus <ko...@gmx.de>.
Just had a closer look at those classes and to me the difference between WebconsoleClient and OsgiConsoleClient is not really obvious.
Shouldn't we rather merge those two?
Konrad
> On 04 May 2016, at 14:47, Andrei Dulvac <an...@gmail.com> wrote:
>
> Hi,
>
> Thanks Radu for applying the docu patch.
> You can find a small section here:
> http://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html#http-based-integration-tests
>
> Cheers,
> - Andrei
>
> On Tue, May 3, 2016 at 11:54 AM Andrei Dulvac <an...@gmail.com>
> wrote:
>
>> Hi guys,
>>
>> Thanks for the explanations. I've added a section in the sling testing
>> page.
>> Please see the mail "CMS diff: Testing Sling-based applications" on the
>> dev list.
>> Could someone have a look?
>>
>> Thanks!
>> - Andrei
>>
>> On Tue, May 3, 2016 at 10:53 AM Bertrand Delacretaz <
>> bdelacretaz@apache.org> wrote:
>>
>>> On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de> wrote:
>>>> Just providing a patch on the markdown pages in the SVN referenced in
>>> [0] should work fine...
>>>
>>> Sure - where cms.apache.org can help is in previewing the changes with
>>> the exact same markdown engine used for sling.apache.org.
>>>
>>> -Bertrand
>>>
>>
Re: Splitting up sling-testing-tools
Posted by Andrei Dulvac <an...@gmail.com>.
Hi,
Thanks Radu for applying the docu patch.
You can find a small section here:
http://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html#http-based-integration-tests
Cheers,
- Andrei
On Tue, May 3, 2016 at 11:54 AM Andrei Dulvac <an...@gmail.com>
wrote:
> Hi guys,
>
> Thanks for the explanations. I've added a section in the sling testing
> page.
> Please see the mail "CMS diff: Testing Sling-based applications" on the
> dev list.
> Could someone have a look?
>
> Thanks!
> - Andrei
>
> On Tue, May 3, 2016 at 10:53 AM Bertrand Delacretaz <
> bdelacretaz@apache.org> wrote:
>
>> On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de> wrote:
>> > Just providing a patch on the markdown pages in the SVN referenced in
>> [0] should work fine...
>>
>> Sure - where cms.apache.org can help is in previewing the changes with
>> the exact same markdown engine used for sling.apache.org.
>>
>> -Bertrand
>>
>
Re: Splitting up sling-testing-tools
Posted by Andrei Dulvac <an...@gmail.com>.
Hi guys,
Thanks for the explanations. I've added a section in the sling testing page.
Please see the mail "CMS diff: Testing Sling-based applications" on the dev
list.
Could someone have a look?
Thanks!
- Andrei
On Tue, May 3, 2016 at 10:53 AM Bertrand Delacretaz <bd...@apache.org>
wrote:
> On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de> wrote:
> > Just providing a patch on the markdown pages in the SVN referenced in
> [0] should work fine...
>
> Sure - where cms.apache.org can help is in previewing the changes with
> the exact same markdown engine used for sling.apache.org.
>
> -Bertrand
>
Re: Splitting up sling-testing-tools
Posted by Bertrand Delacretaz <bd...@apache.org>.
On Tue, May 3, 2016 at 10:46 AM, Konrad Windszus <ko...@gmx.de> wrote:
> Just providing a patch on the markdown pages in the SVN referenced in [0] should work fine...
Sure - where cms.apache.org can help is in previewing the changes with
the exact same markdown engine used for sling.apache.org.
-Bertrand
Re: Splitting up sling-testing-tools
Posted by Konrad Windszus <ko...@gmx.de>.
Just providing a patch on the markdown pages in the SVN referenced in [0] should work fine.
Then any committer can apply that.
> On 03 May 2016, at 10:36, Bertrand Delacretaz <bd...@apache.org> wrote:
>
> Hi,
>
> On Mon, May 2, 2016 at 8:52 PM, Radu Cotescu <ra...@apache.org> wrote:
>> ...If you want to submit a patch for the Sling website you could work with [0]. ..
>
> And http://www.apache.org/dev/cmsref.html#faq explains how
> non-committers can contribute Apache CMS content, but I haven't tried
> that in a while.
>
> -Bertrand
>
>> [0] - https://svn.apache.org/repos/asf/sling/site/trunk/content/
Re: Splitting up sling-testing-tools
Posted by Bertrand Delacretaz <bd...@apache.org>.
Hi,
On Mon, May 2, 2016 at 8:52 PM, Radu Cotescu <ra...@apache.org> wrote:
> ...If you want to submit a patch for the Sling website you could work with [0]. ..
And http://www.apache.org/dev/cmsref.html#faq explains how
non-committers can contribute Apache CMS content, but I haven't tried
that in a while.
-Bertrand
> [0] - https://svn.apache.org/repos/asf/sling/site/trunk/content/
Re: Splitting up sling-testing-tools
Posted by Radu Cotescu <ra...@apache.org>.
Hi Andrei,
If you want to submit a patch for the Sling website you could work with [0].
Cheers,
Radu
[0] - https://svn.apache.org/repos/asf/sling/site/trunk/content/
On Mon, 2 May 2016 at 12:11 Andrei Dulvac <an...@gmail.com> wrote:
> Hey,
>
> I created SLING-5706 with a patch that has a concise README.md with
> examples, which I hope are clear enough to kickstart using the tools.
> Could you guys have a look and if it is ok, apply it?
>
> I don't know how else to provide this patch - I think the stuff that goes
> to cms.apache.org is only reachable by commiters.
>
> Thanks a lot,
> - Andrei
>
> On Fri, Apr 29, 2016 at 5:35 PM Konrad Windszus <ko...@gmx.de> wrote:
>
> > Thanks for that, looks great. Can we have an updated documentation at
> >
> https://sling.apache.org/documentation/tutorials-how-tos/testing-sling-based-applications.html
> ,
> >
> >
> https://sling.apache.org/documentation/bundles/org-apache-sling-junit-bundles.html
> > and
> >
> https://sling.apache.org/documentation/development/sling-testing-tools.html
> > briefly describing the new structure?
> >
> > Thanks,
> > Konrad
> > > On 29 Apr 2016, at 16:32, Bertrand Delacretaz <bd...@apache.org>
> > wrote:
> > >
> > > Hi Andrei,
> > >
> > > On Fri, Apr 29, 2016 at 3:43 PM, Andrei Dulvac <
> andrei.dulvac@gmail.com>
> > wrote:
> > >> ...You can find the PR at: https://github.com/apache/sling/pull/136
> > >> JIRA issue: https://issues.apache.org/jira/browse/SLING-5703...
> > >
> > > Thanks, I've committed this!
> > >
> > > And created SLING-5704 for the eventual move of testing/tools to
> contrib.
> > >
> > > -Bertrand
> >
> >
>