[jira] [Comment Edited] (THRIFT-4938) Issues with version.h treatment

["Jens Geyer (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-4938?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16955299#comment-16955299 ] 

Jens Geyer edited comment on THRIFT-4938 at 10/19/19 10:00 PM:
---------------------------------------------------------------

The real issue is that version.h is handled completely different than any other version number in the source tree. This should be streamlined. SInce veraling is the tool of choice, we should use it here as well.


was (Author: jensg):
The real issue is that version.h is handled completely different than any other version number in the source tree. Due to the fact that version.h is created from version.h.in it is impossible to just open the existing compiler.vcxproj and start a build.

This should be streamlined. SInce veraling is the tool of choice, we should use it here as well.

> Issues with version.h treatment
> -------------------------------
>
>                 Key: THRIFT-4938
>                 URL: https://issues.apache.org/jira/browse/THRIFT-4938
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Compiler
>    Affects Versions: 0.13.0
>         Environment: windows 7, thrift-master,visual studio 2015
>            Reporter: pengzhouhu
>            Assignee: Jens Geyer
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
>       resloved this compatibility display version error because PACKAGE_VERSION value will not be initialization when we built compiler by visual studio 2015. 
>       Maybe few people used to handle project on windows by this IDE, and i think there is still some jobs we need to take to support except that. Need your advice whether i should do these things.
>       Github PR link:[https://github.com/apache/thrift/pull/1853]
>  Thanks.
>  zhouhu.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)