[GitHub] [airflow] eladkal edited a comment on pull request #22123: Add details drawer to Grid View

[GitBox <gi...@apache.org>]

eladkal edited a comment on pull request #22123:
URL: https://github.com/apache/airflow/pull/22123#issuecomment-1073341799


   Played with it a bit in local env this is **really really good!**
   
   Have a few suggestions/bugs **all are minor**:
   
   1. [Suggestion] Can we have the ability to easily copy to clipboard? 
   ![copy2](https://user-images.githubusercontent.com/45845474/159183629-4f88ab8e-1f56-46f6-b059-7c70310b4d65.gif)
   To give example of what i had in mind:
   ![copy](https://user-images.githubusercontent.com/45845474/159183654-952d2d57-9eb1-4864-b4d8-31f8bee10654.gif)
   
   
   
   2. [Tweak] Need to fix the name to Grid also in:
   ![Screen Shot 2022-03-20 at 21 59 25](https://user-images.githubusercontent.com/45845474/159183710-2b6ef089-d72c-40a7-a294-08678d2e9edd.png)
   
   
   
   3. [Bug] When changing Timezone there is a weird "jump" of values :
   ![2022-03-20_22-01-25](https://user-images.githubusercontent.com/45845474/159183827-e6aa5aa9-a4c9-419f-9189-535568c8a6e2.gif)
   Also the timezone changes only in start date but not in Timezone (last row in the table) - why?
   Is this the timezone the DAG is defined with in the code? If so maybe better to call it DAG defined timezone or something like that?
   
   
   
   4. [Bug] When opening the panel a fresh task (state None) when the panel isn't refreshed while the task progresses. So when the task finishes the started/ended values are empty (you must refresh the screen manually to solve this)
   The values in the panel should be refreshed when with the auto-refresh property.
   ![Screen Shot 2022-03-20 at 22 05 58](https://user-images.githubusercontent.com/45845474/159183937-5be5e589-8807-4662-b57a-5f6d1c01098e.png)
   
   
   
   5. [Suggestion] I got a bit lost when clicked on Filter upstream. It was impossible to return where I was before I had to enter the Grid view and repeat my steps. Is there a way to make a better experience with it?
   
   
   
   6. [Suggestion] There are two "More details" one that leads to DAG details and one that leads to Task Details. Can we simply rename it to be "DAG details"/"Task Details"?
   The same goes for "Show Details Panel" It shows different panel for Task/DAG but the button has the same name.
   
   
   
   7. [Bug] I'm not really sure how I managed to do that but I get a tooltip of Show when the button says hide and viseveria. The tool tip is redundant any anyway isn't it?
   ![Screen Shot 2022-03-20 at 22 17 34](https://user-images.githubusercontent.com/45845474/159184340-e113dc89-09eb-4db6-9f58-511ba3851ee4.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org