[jira] [Commented] (BOOKKEEPER-644) Provide a bookie address wrapper

["Rakesh R (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BOOKKEEPER-644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13859906#comment-13859906 ] 

Rakesh R commented on BOOKKEEPER-644:
-------------------------------------

Thanks Sijie for the patch and its really nice work. Since it is touching many files, I'll finish my review in this weekend.

Also, I have a small request, could you please avoid reformatting the whole file(mainly have seen imports/spaces correction etc) which get mixed up with the changes of the patch and makes review hard. I personally feels its good to have format correction if the changes are less, otherwise it will be difficult to see what is going on.

> Provide a bookie address wrapper
> --------------------------------
>
>                 Key: BOOKKEEPER-644
>                 URL: https://issues.apache.org/jira/browse/BOOKKEEPER-644
>             Project: Bookkeeper
>          Issue Type: Sub-task
>          Components: bookkeeper-client, bookkeeper-server
>            Reporter: Sijie Guo
>            Assignee: Sijie Guo
>             Fix For: 4.3.0
>
>         Attachments: BOOKKEEPER-644.diff, BOOKKEEPER-644.diff, BOOKKEEPER-644.diff, BOOKKEEPER-644.diff
>
>
> Provide bookie address wrapper for BOOKKEEPER-629, so client would use the address identifier by server w/o involving in deciding using ip or hostname.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)