[GitHub] [druid] yuanlihan commented on a change in pull request #11960: clean up the balancing code around the batched vs deprecated way of sampling segments to balance

[GitBox <gi...@apache.org>]

yuanlihan commented on a change in pull request #11960:
URL: https://github.com/apache/druid/pull/11960#discussion_r754046654



##########
File path: server/src/main/java/org/apache/druid/server/coordinator/duty/BalanceSegments.java
##########
@@ -202,12 +202,20 @@ private void balanceTier(
     final int maxToLoad = params.getCoordinatorDynamicConfig().getMaxSegmentsInNodeLoadingQueue();
     int moved = 0, unmoved = 0;
 
-    Iterator<BalancerSegmentHolder> segmentsToMove = strategy.pickSegmentsToMove(
-        toMoveFrom,
-        params.getBroadcastDatasources(),
-        params.getCoordinatorDynamicConfig().useBatchedSegmentSampler() ? maxSegmentsToMove : DEFAULT_RESERVOIR_SIZE,

Review comment:
       I think we can delete this unused constant variable




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org