You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by GitBox <gi...@apache.org> on 2021/01/11 09:54:02 UTC

[GitHub] [zeppelin] yejingchen opened a new pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

yejingchen opened a new pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018


   ### What is this PR for?
   Make check_java_version in bin/common.sh check JAVA_HOME if set
   
   
   ### What type of PR is it?
   Bug Fix
   
   ### Todos
   None
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/ZEPPELIN-5195
   
   ### How should this be tested?
   * Strongly recommended: add automated unit tests for any new or changed behavior
   * Outline any manual steps to test the PR here.
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * Does the licenses files need update?
   No
   * Is there breaking changes for older versions?
   No
   * Does this needs documentation?
   No
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] zjffdu commented on pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
zjffdu commented on pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#issuecomment-757991495


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] asfgit closed pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
asfgit closed pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#issuecomment-757980139


   LGTM


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] yejingchen commented on a change in pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
yejingchen commented on a change in pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#discussion_r554978114



##########
File path: bin/common.sh
##########
@@ -66,6 +66,7 @@ fi
 ZEPPELIN_CLASSPATH+=":${ZEPPELIN_CONF_DIR}"
 
 function check_java_version() {
+    [[ ${JAVA_HOME+x} ]] && JAVA="$JAVA_HOME/bin/java"

Review comment:
       Changed to if statement.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on a change in pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
Reamer commented on a change in pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#discussion_r554964655



##########
File path: bin/common.sh
##########
@@ -66,6 +66,7 @@ fi
 ZEPPELIN_CLASSPATH+=":${ZEPPELIN_CONF_DIR}"
 
 function check_java_version() {
+    [[ ${JAVA_HOME+x} ]] && JAVA="$JAVA_HOME/bin/java"

Review comment:
       Please use the syntax `if ; then fi` to be consistent with the rest.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [zeppelin] Reamer commented on pull request #4018: [ZEPPELIN-5195] check JAVA_HOME in check_java_version

Posted by GitBox <gi...@apache.org>.
Reamer commented on pull request #4018:
URL: https://github.com/apache/zeppelin/pull/4018#issuecomment-757984789


   I will include this in master and branch-0.9 on Wednesday if no further comments are received.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org