You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/11/27 11:23:47 UTC

[GitHub] [incubator-kyuubi] pan3793 commented on pull request #3838: [KYUUBI #3839] [Authz] Support signing and verifying `kyuubi.session.user`

pan3793 commented on PR #3838:
URL: https://github.com/apache/incubator-kyuubi/pull/3838#issuecomment-1328225327

   Overall this LGTM, could you please add test cases on server side? I think it should include
   - positive case
   - sign enabled can not disable by session configuration
   - unmatched user and sign
   - sign enabled but no sign in configuration


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@kyuubi.apache.org
For additional commands, e-mail: notifications-help@kyuubi.apache.org