You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/04/20 13:31:24 UTC
[GitHub] [spark] AngersZhuuuu opened a new pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
AngersZhuuuu opened a new pull request #32257:
URL: https://github.com/apache/spark/pull/32257
### What changes were proposed in this pull request?
Add doc about `TRANSFORM` and related function.
### Why are the changes needed?
### Does this PR introduce _any_ user-facing change?
No
### How was this patch tested?
Not need
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828230835
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823342570
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32257:
URL: https://github.com/apache/spark/pull/32257#discussion_r616685825
##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -51,11 +51,11 @@ row_format:
* **row_format**
- Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
+ Uses `SERDE` to specify a custom SerDe to process inputs and outputs or uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
Review comment:
Here update to contains two mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823300225
**[Test build #137688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137688/testReport)** for PR 32257 at commit [`731968f`](https://github.com/apache/spark/commit/731968f4de66fee119fdccfc8899279e4a10bb34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828219943
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828215137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828186067
**[Test build #138030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138030/testReport)** for PR 32257 at commit [`1cbd472`](https://github.com/apache/spark/commit/1cbd4721fc60571b795b1d578b590e923249c122).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823346463
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823300225
**[Test build #137688 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137688/testReport)** for PR 32257 at commit [`731968f`](https://github.com/apache/spark/commit/731968f4de66fee119fdccfc8899279e4a10bb34).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823309805
**[Test build #137688 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/137688/testReport)** for PR 32257 at commit [`731968f`](https://github.com/apache/spark/commit/731968f4de66fee119fdccfc8899279e4a10bb34).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828196217
**[Test build #138030 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138030/testReport)** for PR 32257 at commit [`1cbd472`](https://github.com/apache/spark/commit/1cbd4721fc60571b795b1d578b590e923249c122).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823346463
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/42215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823338559
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/42215/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823310108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu closed pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
maropu closed pull request #32257:
URL: https://github.com/apache/spark/pull/32257
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32257:
URL: https://github.com/apache/spark/pull/32257#discussion_r616686145
##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -51,11 +51,11 @@ row_format:
* **row_format**
- Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
+ Uses `SERDE` to specify a custom SerDe to process inputs and outputs or uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
* **SERDE**
- Specifies a custom SerDe for one table.
+ Specifies a custom SerDe to process inputs and outputs.
Review comment:
Here should not be a table, we use `SerDe` to process data
##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -51,11 +51,11 @@ row_format:
* **row_format**
- Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
+ Uses `SERDE` to specify a custom SerDe to process inputs and outputs or uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
Review comment:
Here update to contains two mode.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on a change in pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on a change in pull request #32257:
URL: https://github.com/apache/spark/pull/32257#discussion_r616686145
##########
File path: docs/sql-ref-syntax-qry-select-transform.md
##########
@@ -51,11 +51,11 @@ row_format:
* **row_format**
- Otherwise, uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
+ Uses `SERDE` to specify a custom SerDe to process inputs and outputs or uses the `DELIMITED` clause to specify the native SerDe and state the delimiter, escape character, null character and so on.
* **SERDE**
- Specifies a custom SerDe for one table.
+ Specifies a custom SerDe to process inputs and outputs.
Review comment:
Here should not be a table, we use `SerDe` to process data
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AngersZhuuuu commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
AngersZhuuuu commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828185121
ping @cloud-fan @maropu
When I back port #31010 to branch 3.0/3.1 I noticed that here's syntax is wrong. and I have modify this in https://github.com/apache/spark/pull/32375 and https://github.com/apache/spark/pull/32376
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828219946
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Fix syntax error in select doc page
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-828186067
**[Test build #138030 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/138030/testReport)** for PR 32257 at commit [`1cbd472`](https://github.com/apache/spark/commit/1cbd4721fc60571b795b1d578b590e923249c122).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #32257: [SPARK-33976][SQL][DOCS][FOLLOWUP] Add a SQL doc page for a TRANSFORM clause
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #32257:
URL: https://github.com/apache/spark/pull/32257#issuecomment-823310108
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/137688/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org