You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by ma...@apache.org on 2009/04/06 14:45:49 UTC

svn commit: r762316 - in /commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl: GenericKeyedObjectPool.java GenericObjectPool.java

Author: markt
Date: Mon Apr  6 12:45:48 2009
New Revision: 762316

URL: http://svn.apache.org/viewvc?rev=762316&view=rev
Log:
Fix some minor Eclipse warnings

Modified:
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
    commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java?rev=762316&r1=762315&r2=762316&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericKeyedObjectPool.java Mon Apr  6 12:45:48 2009
@@ -1527,7 +1527,7 @@
                         }
                     }
                 } catch(Exception e) {
-                    ; // ignored
+                    // ignored
                 }
             }
         }
@@ -1562,8 +1562,7 @@
         }
         ObjectQueue pool = (ObjectQueue) (_poolMap.get(key));
         if (pool != null) {
-            CursorableLinkedList queue = 
-                (CursorableLinkedList)(pool.queue);
+            CursorableLinkedList queue = pool.queue;
             _evictionCursor = queue.cursor(_lifo ? queue.size() : 0);   
         }
     }
@@ -1648,7 +1647,7 @@
         if(_numTestsPerEvictionRun >= 0) {
             return _numTestsPerEvictionRun;
         } else {
-            return(int)(Math.ceil((double)_totalIdle/Math.abs((double)_numTestsPerEvictionRun)));
+            return(int)(Math.ceil(_totalIdle/Math.abs((double)_numTestsPerEvictionRun)));
         }
     }
 

Modified: commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java
URL: http://svn.apache.org/viewvc/commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java?rev=762316&r1=762315&r2=762316&view=diff
==============================================================================
--- commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java (original)
+++ commons/proper/pool/trunk/src/java/org/apache/commons/pool/impl/GenericObjectPool.java Mon Apr  6 12:45:48 2009
@@ -926,7 +926,7 @@
                 try {
                     pair = (ObjectTimestampPair)(_pool.removeFirst());
                 } catch(NoSuchElementException e) {
-                    ; /* ignored */
+                    /* ignored */
                 }
     
                 // otherwise
@@ -1332,7 +1332,7 @@
         if(_numTestsPerEvictionRun >= 0) {
             return Math.min(_numTestsPerEvictionRun, _pool.size());
         } else {
-            return(int)(Math.ceil((double)_pool.size()/Math.abs((double)_numTestsPerEvictionRun)));
+            return(int)(Math.ceil(_pool.size()/Math.abs((double)_numTestsPerEvictionRun)));
         }
     }