You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by djKooks <gi...@git.apache.org> on 2016/09/20 09:34:38 UTC
[GitHub] incubator-predictionio pull request #297: Update document
GitHub user djKooks opened a pull request:
https://github.com/apache/incubator-predictionio/pull/297
Update document
While installing from source with Postgresql, there were no default JDBC driver file, so I add guide for download and setup for this. Please give a comment if there is any problem.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/djKooks/incubator-predictionio develop
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-predictionio/pull/297.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #297
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #297: Update document
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/297
Thanks for your contribution! I don't have a problem with replacing angle brackets with square brackets. The only ask from me is to keep it consistent throughout the whole documentation. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #297: Update document
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-predictionio/pull/297
One more, while I am working on tutorial, there are some broken parts in document that are using angle bracket. It looks it is hard to control on markdown text.
http://stackoverflow.com/questions/20610244/how-to-use-angle-brackets-in-url-on-github-flavored-markdown
How about changing this to square bracket?
This is a suggestion, so please let me know if this is not a good choice.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #297: Update document
Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:
https://github.com/apache/incubator-predictionio/pull/297
@djKooks No problem. Please keep updating. Thanks for your contribution!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #297: Update document
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-predictionio/pull/297
@dszeto Okay thanks! I'll keep update it if there is no problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio issue #297: Update document
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks commented on the issue:
https://github.com/apache/incubator-predictionio/pull/297
@dszeto I reviewed on documents, but only the part that I fixed shows the problem, and other parts used angle bracket shows fine. You can find the problem in link below.
http://predictionio.incubator.apache.org/templates/recommendation/quickstart/
I'm not sure to remove all angle bracket because most of them are working fine, and if I start changing, lots of part need to be changed and maybe some one could be confused in it. Maybe it would be to let it in current state because it is pretty small bug. I'll think about other way to show it clear without replacing it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-predictionio pull request #297: Update document
Posted by djKooks <gi...@git.apache.org>.
Github user djKooks closed the pull request at:
https://github.com/apache/incubator-predictionio/pull/297
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---