You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Aaron Kimball (JIRA)" <ji...@apache.org> on 2009/10/13 23:01:34 UTC
[jira] Created: (HADOOP-6312) Configuration sends too much data to
log4j
Configuration sends too much data to log4j
------------------------------------------
Key: HADOOP-6312
URL: https://issues.apache.org/jira/browse/HADOOP-6312
Project: Hadoop Common
Issue Type: Improvement
Components: conf
Reporter: Aaron Kimball
Assignee: Aaron Kimball
Attachments: HADOOP-6312.patch
Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-6312:
----------------------------------
Status: Patch Available (was: Open)
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765242#action_12765242 ]
Hadoop QA commented on HADOOP-6312:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422020/HADOOP-6312.patch
against trunk revision 824899.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/85/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/85/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/85/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/85/console
This message is automatically generated.
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766717#action_12766717 ]
Chris Douglas commented on HADOOP-6312:
---------------------------------------
Let's just remove it.
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Hadoop QA (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766753#action_12766753 ]
Hadoop QA commented on HADOOP-6312:
-----------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12422403/HADOOP-6312.2.patch
against trunk revision 824942.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified tests.
Please justify why no new tests are needed for this patch.
Also please list what manual steps were performed to verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/90/testReport/
Findbugs warnings: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/90/artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Checkstyle results: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/90/artifact/trunk/build/test/checkstyle-errors.html
Console output: http://hudson.zones.apache.org/hudson/job/Hadoop-Patch-h4.grid.sp2.yahoo.net/90/console
This message is automatically generated.
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766797#action_12766797 ]
Hudson commented on HADOOP-6312:
--------------------------------
Integrated in Hadoop-Common-trunk-Commit #63 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk-Commit/63/])
. Remove unnecessary debug logging in Configuration constructor. Contributed by Aaron Kimball
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-6312:
----------------------------------
Attachment: HADOOP-6312.2.patch
Suits me just fine. New patch.
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-6312:
----------------------------------
Attachment: HADOOP-6312.patch
Patch to change the log level of these statements. Includes no new tests; it's just log4j messages.
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-6312:
----------------------------------
Status: Patch Available (was: Open)
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Aaron Kimball (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Aaron Kimball updated HADOOP-6312:
----------------------------------
Status: Open (was: Patch Available)
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Doug Cutting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12765236#action_12765236 ]
Doug Cutting commented on HADOOP-6312:
--------------------------------------
This looks reasonable to me. Does anyone have concerns about this?
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766877#action_12766877 ]
Hudson commented on HADOOP-6312:
--------------------------------
Integrated in Hadoop-Common-trunk #130 (See [http://hudson.zones.apache.org/hudson/job/Hadoop-Common-trunk/130/])
. Remove unnecessary debug logging in Configuration constructor. Contributed by Aaron Kimball
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-6312) Configuration sends too much data to
log4j
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Chris Douglas updated HADOOP-6312:
----------------------------------
Resolution: Fixed
Hadoop Flags: [Reviewed]
Status: Resolved (was: Patch Available)
I committed this. Thanks Aaron!
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-6312) Configuration sends too much data
to log4j
Posted by "Chris Douglas (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-6312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12766733#action_12766733 ]
Chris Douglas commented on HADOOP-6312:
---------------------------------------
+1
> Configuration sends too much data to log4j
> ------------------------------------------
>
> Key: HADOOP-6312
> URL: https://issues.apache.org/jira/browse/HADOOP-6312
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Aaron Kimball
> Assignee: Aaron Kimball
> Attachments: HADOOP-6312.2.patch, HADOOP-6312.patch
>
>
> Configuration objects send a DEBUG-level log message every time they're instantiated, which include a full stack trace. This is more appropriate for TRACE-level logging, as it renders other debug logs very hard to read.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.