Re: [PR] chore(fe): migrate 4 Enzyme-based tests to RTL [superset]

["rusackas (via GitHub)" <gi...@apache.org>]

rusackas commented on PR #31634:
URL: https://github.com/apache/superset/pull/31634#issuecomment-2651085694

   Hey hey! I'd forgotten about this PR, sorry! 
   
   I'm working on the same effort (killing enzyme) and have this PR going:
   https://github.com/apache/superset/pull/32207
   
   In your PR you get a couple of tests that I also worked on, but you have a couple I haven't gotten to yet. 
   
   It looks like your PR is failing CI on a Cypress test (our next nemesis!) - I just started a re-run of it to see if it passes now. If not, would you rather fix and merge your PR before I merge mine, or would you rather close this and I'll copy over your work on the tests I haven't converted yet?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org