You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benjamin Mahler <bm...@apache.org> on 2019/03/22 15:54:25 UTC
Review Request 70274: Updated quota capacity check to not exclude
disconnected agents.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70274/
-----------------------------------------------------------
Review request for mesos and Meng Zhu.
Bugs: MESOS-6840
https://issues.apache.org/jira/browse/MESOS-6840
Repository: mesos
Description
-------
The exclusion of disconnected agents produces a rather unstable
calculated capacity in the face of upgrades, transient network
issues, etc. To provide a more stable calculated capacity, this
includes registered agents, even when they are disconnected.
This also adds a TODO to include recovered agents so that the
calculated capacity after a failover is the same as it was prior
to the failover.
Diffs
-----
src/master/quota_handler.cpp 2dcfdcaf836f21d7d39b5ef5c36de0db25ca7517
Diff: https://reviews.apache.org/r/70274/diff/1/
Testing
-------
Added a test in the next patch.
Thanks,
Benjamin Mahler
Re: Review Request 70274: Updated quota capacity check to not exclude
disconnected agents.
Posted by Meng Zhu <mz...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70274/#review213957
-----------------------------------------------------------
Ship it!
- Meng Zhu
On March 22, 2019, 8:54 a.m., Benjamin Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70274/
> -----------------------------------------------------------
>
> (Updated March 22, 2019, 8:54 a.m.)
>
>
> Review request for mesos and Meng Zhu.
>
>
> Bugs: MESOS-6840
> https://issues.apache.org/jira/browse/MESOS-6840
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The exclusion of disconnected agents produces a rather unstable
> calculated capacity in the face of upgrades, transient network
> issues, etc. To provide a more stable calculated capacity, this
> includes registered agents, even when they are disconnected.
>
> This also adds a TODO to include recovered agents so that the
> calculated capacity after a failover is the same as it was prior
> to the failover.
>
>
> Diffs
> -----
>
> src/master/quota_handler.cpp 2dcfdcaf836f21d7d39b5ef5c36de0db25ca7517
>
>
> Diff: https://reviews.apache.org/r/70274/diff/1/
>
>
> Testing
> -------
>
> Added a test in the next patch.
>
>
> Thanks,
>
> Benjamin Mahler
>
>