You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@bloodhound.apache.org by Apache Bloodhound <bl...@incubator.apache.org> on 2012/12/17 18:29:32 UTC

[Apache Bloodhound] #311: Comment edit textarea is too narrow

#311: Comment edit textarea is too narrow
-----------------------+-----------------------
 Reporter:  rjollos    |      Owner:  rjollos
     Type:  defect     |     Status:  new
 Priority:  trivial    |  Milestone:  Release 4
Component:  ui design  |    Version:  0.3.0
 Keywords:             |
-----------------------+-----------------------
 It appears that we just need some CSS in `bloodhound.css` that will apply
 to the edit textarea.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:             |   Keywords:  ticket comment
------------------------+----------------------------

Comment (by olemis):

 +1 :)
 further review is needed though

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:4>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+-----------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:             |   Keywords:
------------------------+-----------------------

Comment (by rjollos):

 Here is a screen capture of the current view:

 [[Image(NarrowTextArea.png)]]

 I've provided a fix in [attachment:t311-r1422769-1.patch]. I'm hoping that
 someone proficient in CSS can review.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:1>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:             |   Keywords:  ticket comment
------------------------+----------------------------

Comment (by rjollos):

 Okay, I think I follow you. Does [attachment:t311-r1422769-2.patch]
 capture your suggestion?

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:3>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:  fixed      |   Keywords:  ticket comment
------------------------+----------------------------

Comment (by rjollos):

 Issue has been reported again in #384.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:7>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  closed
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:  fixed      |   Keywords:  ticket comment
------------------------+----------------------------
Changes (by rjollos):

 * status:  new => closed
 * resolution:   => fixed


Comment:

 On second look, issue seems to have been dealt with in #146/r1427699.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:6>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:             |   Keywords:  ticket comment
------------------------+----------------------------
Changes (by olemis):

 * keywords:   => ticket comment


Comment:

 IMO you should keep textarea `id` since plugins might need it as a
 reference e.g. in javascript code, when filtering streams , ... The CSS
 rule should be updated accordingly .

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:2>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker

Re: [Apache Bloodhound] #311: Comment edit textarea is too narrow

Posted by Apache Bloodhound <bl...@incubator.apache.org>.
#311: Comment edit textarea is too narrow
------------------------+----------------------------
  Reporter:  rjollos    |      Owner:  rjollos
      Type:  defect     |     Status:  new
  Priority:  trivial    |  Milestone:  Release 4
 Component:  ui design  |    Version:  0.3.0
Resolution:             |   Keywords:  ticket comment
------------------------+----------------------------

Comment (by rjollos):

 This seems to fix the issue for now, and no one has commented yet, so I'll
 commit the patch for now.

-- 
Ticket URL: <https://issues.apache.org/bloodhound/ticket/311#comment:5>
Apache Bloodhound <https://issues.apache.org/bloodhound/>
The Apache Bloodhound (incubating) issue tracker