[PR] Build: move version-decls from polaris-quarkus-service to libs.versions.toml [polaris]

["snazy (via GitHub)" <gi...@apache.org>]

snazy opened a new pull request, #744:
URL: https://github.com/apache/polaris/pull/744

   
   <!--
       Possible security vulnerabilities: STOP here and contact security@apache.org instead!
   
       Please update the title of the PR with a meaningful message - do not leave it "empty" or "generated"
       Please update this summary field:
   
       The summary should cover these topics, if applicable:
       * the motivation for the change
       * a description of the status quo, for example the current behavior
       * the desired behavior
       * etc
   
       PR checklist:
       - Do a self-review of your code before opening a pull request
       - Make sure that there's good test coverage for the changes included in this PR
       - Run tests locally before pushing a PR (./gradlew check)
       - Code should have comments where applicable. Particularly hard-to-understand
         areas deserve good in-line documentation.
       - Include changes and enhancements to the documentation (in site/content/in-dev/unreleased)
       - For Work In Progress Pull Requests, please use the Draft PR feature.
   
       Make sure to add the information BELOW this comment.
       Everything in this comment will NOT be added to the PR description.
   -->
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Build: move version-decls from polaris-quarkus-service to libs.versions.toml [polaris]

["adutra (via GitHub)" <gi...@apache.org>]

adutra commented on code in PR #744:
URL: https://github.com/apache/polaris/pull/744#discussion_r1914826864


##########
gradle/libs.versions.toml:
##########
@@ -35,6 +37,7 @@ swagger = "1.6.14"
 # If a dependency is removed, check whether the LICENSE and/or NOTICE files need to be adopted
 # (aka mention of the dependency removed).
 #
+antlr4-runtime = { module = "org.antlr:antlr4-runtime", version.strictly = "4.9.3" }

Review Comment:
   Maybe add a comment here that `version.strictly` is because of Spark IT.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Build: move version-decls from polaris-quarkus-service to libs.versions.toml [polaris]

["snazy (via GitHub)" <gi...@apache.org>]

snazy merged PR #744:
URL: https://github.com/apache/polaris/pull/744


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@polaris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org