You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@oozie.apache.org by Zsombor Gegesy <zs...@apache.org> on 2019/11/04 13:52:41 UTC

Review Request 71714: OOZIE-3555: Remove unnecessary StandardCharsets.UTF_8.name() calls - where Charset could be accepted as well

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71714/
-----------------------------------------------------------

Review request for oozie.


Bugs: OOZIE-3555
    https://issues.apache.org/jira/browse/OOZIE-3555


Repository: oozie-git


Description
-------

Lot of places, Oozie could pass a Charset object, instead of a name of a Charset.


Diffs
-----

  core/src/main/java/org/apache/oozie/compression/CodecFactory.java e139c8072 
  core/src/main/java/org/apache/oozie/util/StringSerializationUtil.java 54196d80d 
  core/src/main/java/org/apache/oozie/util/schema/Input.java ea23d6331 
  core/src/test/java/org/apache/oozie/action/hadoop/TestJavaActionExecutor.java 62ce7febd 
  core/src/test/java/org/apache/oozie/command/coord/TestCoordRerunXCommand.java 61b9022e2 
  core/src/test/java/org/apache/oozie/compression/TestCodecFactory.java 79bbc6319 
  core/src/test/java/org/apache/oozie/servlet/TestJobsServlet.java c59858d6f 
  core/src/test/java/org/apache/oozie/servlet/TestV1AdminServlet.java 5f436c847 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobServlet.java ea2608117 
  core/src/test/java/org/apache/oozie/servlet/TestV1JobsServlet.java 2f3a9012c 
  core/src/test/java/org/apache/oozie/servlet/TestV2JobServlet.java 070cf3601 
  sharelib/hive/src/main/java/org/apache/oozie/action/hadoop/HiveMain.java 37819d1b4 
  sharelib/hive2/src/main/java/org/apache/oozie/action/hadoop/Hive2Main.java 0d8ee1bbd 
  sharelib/pig/src/main/java/org/apache/oozie/action/hadoop/PigMain.java e17c07fbe 
  sharelib/spark/src/main/java/org/apache/oozie/action/hadoop/SparkArgsExtractor.java ff1f1bb24 
  sharelib/streaming/src/test/java/org/apache/oozie/action/hadoop/TestMapReduceActionExecutor.java 75b94d110 
  tools/src/main/java/org/apache/oozie/tools/OozieDBCLI.java a577cc095 
  tools/src/main/java/org/apache/oozie/tools/OozieDBExportCLI.java 340572e61 
  tools/src/main/java/org/apache/oozie/tools/diag/DiagBundleEntryWriter.java 8485f6a7a 
  tools/src/test/java/org/apache/oozie/tools/diag/TestMetricsCollector.java c5766ca34 
  tools/src/test/java/org/apache/oozie/tools/diag/TestServerInfoCollector.java a47defaca 


Diff: https://reviews.apache.org/r/71714/diff/1/


Testing
-------

Tested locally


Thanks,

Zsombor Gegesy