You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/08/12 09:52:21 UTC

[GitHub] [iotdb] CRZbulabula commented on a diff in pull request #6979: [IOTDB-4112] Decoupling heartbeat scheduled executor service from LoadManager

CRZbulabula commented on code in PR #6979:
URL: https://github.com/apache/iotdb/pull/6979#discussion_r944301945


##########
confignode/src/main/java/org/apache/iotdb/confignode/procedure/env/ConfigNodeProcedureEnv.java:
##########
@@ -203,9 +203,6 @@ public void removeConfigNodePeer(TConfigNodeLocation tConfigNodeLocation)
     try {
       // Execute removePeer
       if (getConsensusManager().removeConfigNodePeer(tConfigNodeLocation)) {
-        configManager
-            .getLoadManager()
-            .removeNodeHeartbeatHandCache(tConfigNodeLocation.getConfigNodeId());

Review Comment:
   I suppose that there is not need to make the cache management more intricate. Because the NodeCache and RegionGroupCache are limited and they will be discarded as long as the ConfigNode-leader changed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org