You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/04/14 08:55:26 UTC

[GitHub] [airflow] potiuk commented on a diff in pull request #22998: Add nicer error for breeze update static check

potiuk commented on code in PR #22998:
URL: https://github.com/apache/airflow/pull/22998#discussion_r850232461


##########
scripts/ci/pre_commit/pre_commit_breeze_cmd_line.py:
##########
@@ -79,6 +80,19 @@ def verify_all_commands_described_in_docs():
         sys.exit(1)
 
 
+def verify_breeze_installed():
+    result = subprocess.getoutput('breeze version')

Review Comment:
   Yeah. Shutil.which is better. It's also portable and it's enough (we don't verify the output of `version` command anyway.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org