You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by GitBox <gi...@apache.org> on 2020/07/21 07:24:39 UTC
[GitHub] [mina-sshd] gnodet opened a new pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
gnodet opened a new pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144
renamed: sshd-mina: org.apache.sshd.common.io.mina -> sshd-mina: org.apache.sshd.mina
renamed: sshd-openpgp: org.apache.sshd.common.config.keys.loader.openpgp -> sshd-openpgp: org.apache.sshd.openpgp
renamed: sshd-putty: org.apache.sshd.common.config.keys.loader.putty -> sshd-putty: org.apache.sshd.putty
renamed: sshd-scp: org.apache.sshd.client.scp -> sshd-scp: org.apache.sshd.scp.client
renamed: sshd-scp: org.apache.sshd.common.scp -> sshd-scp: org.apache.sshd.scp.common
renamed: sshd-scp: org.apache.sshd.common.scp.helpers -> sshd-scp: org.apache.sshd.scp.common.helpers
renamed: sshd-scp: org.apache.sshd.server.scp -> sshd-scp: org.apache.sshd.scp.server
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp -> sshd-sftp: org.apache.sshd.sftp.client
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.extensions -> sshd-sftp: org.apache.sshd.sftp.client.extensions
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.extensions.helpers -> sshd-sftp: org.apache.sshd.sftp.client.extensions.helpers
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.extensions.openssh -> sshd-sftp: org.apache.sshd.sftp.client.extensions.openssh
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.extensions.openssh.helpers -> sshd-sftp: org.apache.sshd.sftp.client.extensions.openssh.helpers
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.fs -> sshd-sftp: org.apache.sshd.sftp.client.fs
renamed: sshd-sftp: org.apache.sshd.client.subsystem.sftp.impl -> sshd-sftp: org.apache.sshd.sftp.client.impl
renamed: sshd-sftp: org.apache.sshd.common.subsystem.sftp -> sshd-sftp: org.apache.sshd.sftp.common
renamed: sshd-sftp: org.apache.sshd.common.subsystem.sftp.extensions -> sshd-sftp: org.apache.sshd.sftp.common.extensions
renamed: sshd-sftp: org.apache.sshd.common.subsystem.sftp.extensions.openssh -> sshd-sftp: org.apache.sshd.sftp.common.extensions.openssh
renamed: sshd-sftp: org.apache.sshd.server.subsystem.sftp -> sshd-sftp: org.apache.sshd.sftp.server
renamed: sshd-spring-sftp: org.apache.sshd.spring.integration.sftp -> sshd-spring-sftp: org.apache.sshd.sftp.spring.integration
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet edited a comment on pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
gnodet edited a comment on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-661711941
> Looks promising - don't forget `sshd-ldap`...
Done
> Need to figure out something for `sshd-common` and `sshd-core` if possible. If you do that, then need to review if we still need to create `sshd-osgi` artifact.
Not sure how to do that. I fail to clearly understand where the separation has been drawn between `sshd-core` and `sshd-common`. We could eventually split between `o.a.sshd.common`, `o.a.sshd.client`, `o.a.sshd.server` and `o.a.sshd.agent` into 4 maven modules (`common`, `client`, `server`, `agent`). That should allow to move the OSGi metadata into these modules and get rid of `sshd-osgi`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet commented on pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
gnodet commented on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-661711941
> Looks promising - don't forget `sshd-ldap`...
Done
> Need to figure out something for `sshd-common` and `sshd-core` if possible. If you do that, then need to review if we still need to create `sshd-osgi` artifact.
Not sure how to do that. I fail to clearly understand where the separation has been drawn between {{sshd-core}} and {{sshd-common}}. We could eventually split between {{o.a.sshd.common}}, {{o.a.sshd.client}}, {{o.a.sshd.server}} and {{o.a.sshd.agent}} into 4 maven modules (common, client, server, agent).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet edited a comment on pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
gnodet edited a comment on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-661711941
> Looks promising - don't forget `sshd-ldap`...
Done
> Need to figure out something for `sshd-common` and `sshd-core` if possible. If you do that, then need to review if we still need to create `sshd-osgi` artifact.
Not sure how to do that. I fail to clearly understand where the separation has been drawn between `sshd-core` and `sshd-common`. We could eventually split between `o.a.sshd.common`, `o.a.sshd.client`, `o.a.sshd.server` and `o.a.sshd.agent` into 4 maven modules (`common`, `client`, `server`, `agent`).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
lgoldstein commented on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-661687406
Looks promising - don't forget `sshd-ldap`...
Need to figure out something for `sshd-common` and `sshd-core` if possible. If you do that, then need to review if we still need to create `sshd-osgi` artifact.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] lgoldstein commented on pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
lgoldstein commented on pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144#issuecomment-662269701
>> I fail to clearly understand where the separation has been drawn between sshd-core and sshd-common.
I agree - it was an ongoing attempt to preserve package names and just move classes. The basic criterion I used is `sshd-common` tests do not require an active client/server whereas `sshd-core` ones do.
>> We could eventually split between o.a.sshd.common, o.a.sshd.client, o.a.sshd.server and o.a.sshd.agent into 4 maven modules (common, client, server, agent). That should allow to move the OSGi metadata into these modules and get rid of sshd-osgi.
That would be a good solution though I fear the separation is not quite clean-cut since some classes are required by both client and server - so we might need 5 modules: `sshd-common` for all sort of utilities, `sshd-core` for classes that are required by both client and server and then 'client, server, agent`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org
[GitHub] [mina-sshd] gnodet merged pull request #144: [SSHD-1038] Refactor packages from a module into a cleaner hierarchy
Posted by GitBox <gi...@apache.org>.
gnodet merged pull request #144:
URL: https://github.com/apache/mina-sshd/pull/144
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@mina.apache.org
For additional commands, e-mail: dev-help@mina.apache.org