You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@datasketches.apache.org by "tisonkun (via GitHub)" <gi...@apache.org> on 2025/12/15 11:09:58 UTC
[PR] chore: fine tune asfyaml settings (datasketches-rust)
tisonkun opened a new pull request, #19:
URL: https://github.com/apache/datasketches-rust/pull/19
This is based on https://github.com/apache/datasketches-rust/pull/18 to make CI passed.
I can do the rebase once #18 gets merged.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] chore: fine tune asfyaml settings (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19:
URL: https://github.com/apache/datasketches-rust/pull/19#discussion_r2618988019
##########
.asf.yaml:
##########
@@ -28,28 +32,19 @@ github:
squash: true
merge: false
rebase: false
-# protected_branches:
-# main:
-# required_status_checks:
- # strict means "Require branches to be up to date before merging."
-# strict: true
-
-# required_pull_request_reviews:
-# dismiss_stale_reviews: false
-# required_approving_review_count: 1
-
- # squash or rebase must be allowed in the repo for this setting to be set to true.
-# required_linear_history: false
-
-# required_signatures: false
-
- # requires all conversations to be resolved before merging is possible
-# required_conversation_resolution: false
+ del_branch_on_merge: true
+ protected_branches:
+ main:
+ required_status_checks:
+ contexts:
+ - Required
Review Comment:
It should be "the names of checks". But what "the name" is is vague.
I checked my previous work on [Apache Pulsar](https://github.com/apache/pulsar/blob/9937d22ffea22b199fd5782153ebb4a9c2f25391/.asf.yaml#L44-L51). Hopefully, we can get it right the first time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] chore: fine tune asfyaml settings (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19:
URL: https://github.com/apache/datasketches-rust/pull/19#discussion_r2618993289
##########
.asf.yaml:
##########
@@ -28,28 +32,19 @@ github:
squash: true
merge: false
rebase: false
-# protected_branches:
-# main:
-# required_status_checks:
- # strict means "Require branches to be up to date before merging."
-# strict: true
-
-# required_pull_request_reviews:
-# dismiss_stale_reviews: false
-# required_approving_review_count: 1
-
- # squash or rebase must be allowed in the repo for this setting to be set to true.
-# required_linear_history: false
-
-# required_signatures: false
-
- # requires all conversations to be resolved before merging is possible
-# required_conversation_resolution: false
+ del_branch_on_merge: true
+ protected_branches:
+ main:
+ required_status_checks:
+ contexts:
+ - Required
+ required_pull_request_reviews:
+ required_approving_review_count: 1
Review Comment:
It would require a committer's pull request to have one more approving review before merging. But it should be fine as long as we have several active committers overseeing this repo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] chore: fine tune asfyaml settings (datasketches-rust)
Posted by "tisonkun (via GitHub)" <gi...@apache.org>.
tisonkun commented on code in PR #19:
URL: https://github.com/apache/datasketches-rust/pull/19#discussion_r2618978459
##########
.asf.yaml:
##########
@@ -15,11 +15,15 @@
# specific language governing permissions and limitations
# under the License.
+# All configurations could be found here: https://github.com/apache/infrastructure-asfyaml/
+
github:
description: A software library of stochastic streaming algorithms, a.k.a. sketches.
homepage: https://datasketches.apache.org
- ghp_branch: gh-pages
- ghp_path: /docs
Review Comment:
.. until we really need it. I guess most of our docs would either go to https://datasketches.apache.org/ or https://docs.rs/datasketches.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org
Re: [PR] chore: fine tune asfyaml settings (datasketches-rust)
Posted by "freakyzoidberg (via GitHub)" <gi...@apache.org>.
freakyzoidberg merged PR #19:
URL: https://github.com/apache/datasketches-rust/pull/19
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@datasketches.apache.org
For additional commands, e-mail: dev-help@datasketches.apache.org