You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/06/30 17:13:44 UTC

[GitHub] [netbeans] troizet opened a new pull request, #4306: Git: replace invalid characters in branch name

troizet opened a new pull request, #4306:
URL: https://github.com/apache/netbeans/pull/4306

   Hi! I've made an option for git that implements the feature from issue #3980.
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
mbien commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1172863082

   all green, did some manual testing + travis is idle -> merging
   
   @troizet thanks for your contribution


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] troizet commented on pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
troizet commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1172487115

   @mbien I have corrected the above mentioned shortcomings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] troizet commented on a diff in pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
troizet commented on code in PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#discussion_r912079146


##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -111,8 +115,8 @@ private void validate () {
             setErrorMessage(msgInvalidName);
         }
         if (flag) {
-            setErrorMessage(null);
-        }
+                setErrorMessage(null);
+            }

Review Comment:
   This is left over from my experiments.



##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -146,7 +150,7 @@ private void validateName () {
         if (branchName.isEmpty()) {
             msgInvalidName = Bundle.MSG_CreateBranch_errorBranchNameEmpty();
         } else if (!GitUtils.isValidBranchName(branchName)) {
-            msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();
+                msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();

Review Comment:
   same



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien merged pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
mbien merged PR #4306:
URL: https://github.com/apache/netbeans/pull/4306


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] troizet commented on a diff in pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
troizet commented on code in PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#discussion_r912079488


##########
ide/git/src/org/netbeans/modules/git/options/GitOptionsPanel.java:
##########
@@ -149,7 +157,7 @@ private void initComponents() {
                     .addComponent(jLabel2)
                     .addComponent(txtProjectAnnotation, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
                     .addComponent(btnAddVariable))
-                .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
+                .addContainerGap(10, Short.MAX_VALUE))

Review Comment:
   Fixed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jepsar commented on pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
jepsar commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1259551597

   For anyone ending up here by searching: this feature must be enabled first:
   
   <img width="851" alt="Screenshot 2022-09-27 at 15 56 16" src="https://user-images.githubusercontent.com/7500178/192546827-2af745b3-e047-4944-9650-72de6f397521.png">
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

Re: [PR] Git: replace invalid characters in branch name [netbeans]

Posted by "mbien (via GitHub)" <gi...@apache.org>.
mbien commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1757479414

   we likely going to enable this by default now #6555


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] jepsar commented on pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
jepsar commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1173506997

   @troizet Thanks for your fix!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] mbien commented on a diff in pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
mbien commented on code in PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#discussion_r911501380


##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -146,7 +150,7 @@ private void validateName () {
         if (branchName.isEmpty()) {
             msgInvalidName = Bundle.MSG_CreateBranch_errorBranchNameEmpty();
         } else if (!GitUtils.isValidBranchName(branchName)) {
-            msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();
+                msgInvalidName = Bundle.MSG_CreateBranch_errorInvalidBranchName();

Review Comment:
   same here



##########
ide/git/src/org/netbeans/modules/git/ui/branch/CreateBranch.java:
##########
@@ -111,8 +115,8 @@ private void validate () {
             setErrorMessage(msgInvalidName);
         }
         if (flag) {
-            setErrorMessage(null);
-        }
+                setErrorMessage(null);
+            }

Review Comment:
   what happened here? ;)



##########
ide/git/src/org/netbeans/modules/git/options/GitOptionsPanel.java:
##########
@@ -149,7 +157,7 @@ private void initComponents() {
                     .addComponent(jLabel2)
                     .addComponent(txtProjectAnnotation, javax.swing.GroupLayout.PREFERRED_SIZE, javax.swing.GroupLayout.DEFAULT_SIZE, javax.swing.GroupLayout.PREFERRED_SIZE)
                     .addComponent(btnAddVariable))
-                .addContainerGap(javax.swing.GroupLayout.DEFAULT_SIZE, Short.MAX_VALUE))
+                .addContainerGap(10, Short.MAX_VALUE))

Review Comment:
   could you go though all check boxes in this panel and do the following:
    - right click -> Edit Layout Space...
    - make sure Top and Bottom is set to "default medium"
   
   so that we don't have fixed gaps defined, this would look inconsistent if if some UI settings change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] troizet commented on pull request #4306: Git: replace invalid characters in branch name

Posted by GitBox <gi...@apache.org>.
troizet commented on PR #4306:
URL: https://github.com/apache/netbeans/pull/4306#issuecomment-1172487226

   @mbien I have corrected the above mentioned shortcomings.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists