You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@curator.apache.org by Mike Drob <ma...@cloudera.com> on 2014/09/10 01:53:46 UTC
JIRA in Commit Message
On the discussion for https://github.com/apache/curator/pull/41 Jordan made
a very interesting comment:
> If the branch is named the same as the Jira it's not necessary to put the
Jira in the commit.
This makes me think that there is some git-fu that I am missing out on,
because I'm not sure how to always do this.
As a case study, let's say that I'm trying to figure out what issue commit
462121f is associated with. I know that I can go to github, and search for
that text, filter to issues and I see CURATOR-33 come up (personally I
think this is a lot of steps, but it works so I don't mind), but if I'm
working on a train or plane with bad signal then I'm not sure how to deduce
this out using my local repository.
If somebody has already figured it out, what is your workflow? Or does this
not come up often for other folks to care?
Thanks,
Mike
Re: JIRA in Commit Message
Posted by Mike Drob <ma...@cloudera.com>.
I've heard good things about gitx, but AFAIK it's still Mac only. :(
I already have a similar alias for using 'log --graph' - I guess I can take
the graph output, search for the commit there and then trace the line up
until I see a branch name? That feels... imprecise, but potentially
manageable. I'll try it next time, thanks.
On Tue, Sep 9, 2014 at 5:01 PM, Jordan Zimmerman <jordan@jordanzimmerman.com
> wrote:
> You can use a tool like gitx or, for bash, add this to your bash profile:
>
> glog() {
>
> git log --color --graph --pretty=format:'%Cred%h%Creset
> -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset'
> --abbrev-commit
>
> }
>
> Then glog looks like this:
>
> * f9c6919 - (HEAD, origin/master, master, CURATOR-84) Merge branch
> 'master' into CURATOR-84 (2 weeks ago) <randgalt>
>
> |\
>
> | * 7d30d3d - (CURATOR-142) Merge branch 'CURATOR-142' of github.com:madrob/curator
> into CURATOR-142 (3 weeks ago) <randgalt>
>
> | |\
>
> | | * 72934da - (madrob/CURATOR-142) CURATOR-142 Make forkCount
> configurable (3 weeks ago) <Mike Drob>
>
> | * | f8aabb0 - (CURATOR-79) Merge branch 'master' into CURATOR-79 (3
> weeks ago) <randgalt>
>
> | |\ \
>
> | | * \ 053feb4 - (CURATOR-132) Merge branch 'master' into CURATOR-132 (3
> weeks ago) <randgalt>
>
> | | |\ \
>
> | | | * \ 7bec246 - (CURATOR-136) Merge branch 'CURATOR-136' of
> github.com:madrob/curator into CURATOR-136 (3 weeks ago) <randgalt>
>
> | | | |\ \
>
> | | | | * | 05254af - (madrob/CURATOR-136) CURATOR-136 Consistent relpath
> handling in recipes (3 weeks ago) <Mike Drob>
>
> | | | | |/
>
> | | | * | e6fc38c - closes #34 - no longer needed (3 weeks ago) <randgalt>
>
> | | | * | bc81d75 - closes #16 Given that we will deprecate these classes
> I don't think this is needed anymore (3 weeks ago) <randgalt>
>
> | | | |/
>
> | | * | 9735138 - (origin/CURATOR-132) CURATOR-132 - Modified the
> NamespaceFacade so that it does not proxy getACL() and setACL() calls to
> the underlying clie
>
> | * | | c92ffee - (origin/CURATOR-79) CURATOR-79 - Modified exception
> handling to occur in a single block. Updated some minor unit test niceties. (4
> weeks ago
>
> | * | | 5398b72 - CURATOR-79 - Modified the 'withProtection' handling, so
> that any failure that is not a ConnectionLossException or other
> KeeperException is t
>
> * | | | 942e23d - (origin/CURATOR-84) minor re-format (2 weeks ago)
> <randgalt>
>
> * | | | d5f5517 - CURATOR-84 - Fixed up formatting (3 weeks ago) <Cam
> McKenzie>
>
> * | | | 6b19fe2 - Merge branch 'CURATOR-84' of
> https://github.com/karkum/curator into CURATOR-84 (3 weeks ago) <Cam
> McKenzie>
>
> |\ \ \ \
>
> | * | | | 6ecfd79 - CURATOR-84 More flexibility for InterProcessMutex
> extensions (3 weeks ago) <Karthik Kumar>
>
> * | | | | 475a3b0 - Merge branch 'CURATOR-84' of
> https://github.com/karkum/curator into CURATOR-84 (3 weeks ago) <Cam
> McKenzie>
>
> |\ \ \ \ \
>
> | |_|_|_|/
>
> |/| | | |
>
> | * | | | 882f541 - CURATOR-84 More flexibility for InterProcessMutex
> extensions (3 weeks ago) <Karthik Kumar>
>
> | |/ / /
>
> * | | | 0d1397a - (origin/CURATOR-141) CURATOR-141 - Reverted the logging
> additions to the pom.xml as they have already been covered by CURATOR-139 (3
> weeks a
>
> * | | | c623053 - Merge branch 'CURATOR-141' of
> https://github.com/karel1980/curator into CURATOR-141 (3 weeks ago) <Cam
> McKenzie>
>
> |\ \ \ \
>
> | * | | | 4f9d27a - CURATOR-141 Changed the way we detect a working log
> setup (3 weeks ago) <Karel Vervaeke>
>
> | * | | | f2f1953 - CURATOR-141 Don't make calls to the client after
> PathChildrenCache has been closed. (4 weeks ago) <Karel Vervaeke>
>
> | |/ / /
>
> * | | | 104837d - (origin/CURATOR-139) CURATOR-139 Add slf4j-log4j test
> bindings (4 weeks ago) <Mike Drob>
>
> |/ / /
>
> * | | d2c37d0 - (origin/CURATOR-131) Merge branch 'CURATOR-131' of
> https://github.com/madrob/curator into CURATOR-131 (4 weeks ago) <Cam
> McKenzie>
>
> |\ \ \
>
>
> On September 9, 2014 at 6:54:32 PM, Mike Drob (madrob@cloudera.com) wrote:
>
> On the discussion for https://github.com/apache/curator/pull/41 Jordan
> made
> a very interesting comment:
>
> > If the branch is named the same as the Jira it's not necessary to put
> the
> Jira in the commit.
>
> This makes me think that there is some git-fu that I am missing out on,
> because I'm not sure how to always do this.
>
> As a case study, let's say that I'm trying to figure out what issue commit
> 462121f is associated with. I know that I can go to github, and search for
> that text, filter to issues and I see CURATOR-33 come up (personally I
> think this is a lot of steps, but it works so I don't mind), but if I'm
> working on a train or plane with bad signal then I'm not sure how to
> deduce
> this out using my local repository.
>
> If somebody has already figured it out, what is your workflow? Or does
> this
> not come up often for other folks to care?
>
> Thanks,
> Mike
>
>
Re: JIRA in Commit Message
Posted by Jordan Zimmerman <jo...@jordanzimmerman.com>.
You can use a tool like gitx or, for bash, add this to your bash profile:
glog() {
git log --color --graph --pretty=format:'%Cred%h%Creset -%C(yellow)%d%Creset %s %Cgreen(%cr) %C(bold blue)<%an>%Creset' --abbrev-commit
}
Then glog looks like this:
* f9c6919 - (HEAD, origin/master, master, CURATOR-84) Merge branch 'master' into CURATOR-84 (2 weeks ago) <randgalt>
|\
| * 7d30d3d - (CURATOR-142) Merge branch 'CURATOR-142' of github.com:madrob/curator into CURATOR-142 (3 weeks ago) <randgalt>
| |\
| | * 72934da - (madrob/CURATOR-142) CURATOR-142 Make forkCount configurable (3 weeks ago) <Mike Drob>
| * | f8aabb0 - (CURATOR-79) Merge branch 'master' into CURATOR-79 (3 weeks ago) <randgalt>
| |\ \
| | * \ 053feb4 - (CURATOR-132) Merge branch 'master' into CURATOR-132 (3 weeks ago) <randgalt>
| | |\ \
| | | * \ 7bec246 - (CURATOR-136) Merge branch 'CURATOR-136' of github.com:madrob/curator into CURATOR-136 (3 weeks ago) <randgalt>
| | | |\ \
| | | | * | 05254af - (madrob/CURATOR-136) CURATOR-136 Consistent relpath handling in recipes (3 weeks ago) <Mike Drob>
| | | | |/
| | | * | e6fc38c - closes #34 - no longer needed (3 weeks ago) <randgalt>
| | | * | bc81d75 - closes #16 Given that we will deprecate these classes I don't think this is needed anymore (3 weeks ago) <randgalt>
| | | |/
| | * | 9735138 - (origin/CURATOR-132) CURATOR-132 - Modified the NamespaceFacade so that it does not proxy getACL() and setACL() calls to the underlying clie
| * | | c92ffee - (origin/CURATOR-79) CURATOR-79 - Modified exception handling to occur in a single block. Updated some minor unit test niceties. (4 weeks ago
| * | | 5398b72 - CURATOR-79 - Modified the 'withProtection' handling, so that any failure that is not a ConnectionLossException or other KeeperException is t
* | | | 942e23d - (origin/CURATOR-84) minor re-format (2 weeks ago) <randgalt>
* | | | d5f5517 - CURATOR-84 - Fixed up formatting (3 weeks ago) <Cam McKenzie>
* | | | 6b19fe2 - Merge branch 'CURATOR-84' of https://github.com/karkum/curator into CURATOR-84 (3 weeks ago) <Cam McKenzie>
|\ \ \ \
| * | | | 6ecfd79 - CURATOR-84 More flexibility for InterProcessMutex extensions (3 weeks ago) <Karthik Kumar>
* | | | | 475a3b0 - Merge branch 'CURATOR-84' of https://github.com/karkum/curator into CURATOR-84 (3 weeks ago) <Cam McKenzie>
|\ \ \ \ \
| |_|_|_|/
|/| | | |
| * | | | 882f541 - CURATOR-84 More flexibility for InterProcessMutex extensions (3 weeks ago) <Karthik Kumar>
| |/ / /
* | | | 0d1397a - (origin/CURATOR-141) CURATOR-141 - Reverted the logging additions to the pom.xml as they have already been covered by CURATOR-139 (3 weeks a
* | | | c623053 - Merge branch 'CURATOR-141' of https://github.com/karel1980/curator into CURATOR-141 (3 weeks ago) <Cam McKenzie>
|\ \ \ \
| * | | | 4f9d27a - CURATOR-141 Changed the way we detect a working log setup (3 weeks ago) <Karel Vervaeke>
| * | | | f2f1953 - CURATOR-141 Don't make calls to the client after PathChildrenCache has been closed. (4 weeks ago) <Karel Vervaeke>
| |/ / /
* | | | 104837d - (origin/CURATOR-139) CURATOR-139 Add slf4j-log4j test bindings (4 weeks ago) <Mike Drob>
|/ / /
* | | d2c37d0 - (origin/CURATOR-131) Merge branch 'CURATOR-131' of https://github.com/madrob/curator into CURATOR-131 (4 weeks ago) <Cam McKenzie>
|\ \ \
On September 9, 2014 at 6:54:32 PM, Mike Drob (madrob@cloudera.com) wrote:
On the discussion for https://github.com/apache/curator/pull/41 Jordan made
a very interesting comment:
> If the branch is named the same as the Jira it's not necessary to put the
Jira in the commit.
This makes me think that there is some git-fu that I am missing out on,
because I'm not sure how to always do this.
As a case study, let's say that I'm trying to figure out what issue commit
462121f is associated with. I know that I can go to github, and search for
that text, filter to issues and I see CURATOR-33 come up (personally I
think this is a lot of steps, but it works so I don't mind), but if I'm
working on a train or plane with bad signal then I'm not sure how to deduce
this out using my local repository.
If somebody has already figured it out, what is your workflow? Or does this
not come up often for other folks to care?
Thanks,
Mike