You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/06/30 12:30:59 UTC

[GitHub] [arrow] crcrpar opened a new pull request #7590: [C++] Fix docs of reading CSV files

crcrpar opened a new pull request #7590:
URL: https://github.com/apache/arrow/pull/7590


   Hi,
   
   This is my first PR for this awesome project. So if I do not follow the workflow, could you tell me, please?
   
   In this PR, I aim at fixing https://arrow.apache.org/docs/cpp/csv.html?highlight=csv%20c#basic-usage as I found the example not working in my environment (arrow v0.17.1).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] crcrpar commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
crcrpar commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651835046


   @pitrou My pleasure :smiley: 
   
   Yes, I think so as the use of `arrow::Result` in my commits might be confusing.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651769268


   Thank you for spotting this and suggesting a fix! I will make a couple changes to your suggestion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] crcrpar commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
crcrpar commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651844844


   I'm so impressed by your quick response! Thanks!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651773473


   @crcrpar  Do you think the version I pushed is ok and clear enough?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou closed pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #7590:
URL: https://github.com/apache/arrow/pull/7590


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7590: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651761199


   <!--
     Licensed to the Apache Software Foundation (ASF) under one
     or more contributor license agreements.  See the NOTICE file
     distributed with this work for additional information
     regarding copyright ownership.  The ASF licenses this file
     to you under the Apache License, Version 2.0 (the
     "License"); you may not use this file except in compliance
     with the License.  You may obtain a copy of the License at
   
       http://www.apache.org/licenses/LICENSE-2.0
   
     Unless required by applicable law or agreed to in writing,
     software distributed under the License is distributed on an
     "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
     KIND, either express or implied.  See the License for the
     specific language governing permissions and limitations
     under the License.
   -->
   
   Thanks for opening a pull request!
   
   Could you open an issue for this pull request on JIRA?
   https://issues.apache.org/jira/browse/ARROW
   
   Then could you also rename pull request title in the following format?
   
       ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
   
   See also:
   
     * [Other pull requests](https://github.com/apache/arrow/pulls/)
     * [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] pitrou commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651836379


   Thank you for your contribution. Please don't hesitate to report other doc problems.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [arrow] github-actions[bot] commented on pull request #7590: ARROW-9277: [C++] Fix docs of reading CSV files

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #7590:
URL: https://github.com/apache/arrow/pull/7590#issuecomment-651768214


   https://issues.apache.org/jira/browse/ARROW-9277


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org