You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by r-kamath <gi...@git.apache.org> on 2015/12/09 10:22:16 UTC
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
GitHub user r-kamath opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/525
Interpreter properties editor updates
- Add extra validations in add new interpreter property function to
prevent 'undefined'
- Instead of an empty table show a message when there are no properties to display
- Apply bootstrap style for the table
Before
<img width="1370" alt="screen shot 2015-12-09 at 2 34 48 pm" src="https://cloud.githubusercontent.com/assets/2031306/11681329/4bbfced0-9e84-11e5-995a-60dd73b7eded.png">
<img width="1669" alt="screen shot 2015-12-09 at 2 34 36 pm" src="https://cloud.githubusercontent.com/assets/2031306/11681330/4bc33a34-9e84-11e5-9fd9-0d5a961d6ee5.png">
<hr>
After
<img width="1651" alt="screen shot 2015-12-09 at 2 36 07 pm" src="https://cloud.githubusercontent.com/assets/2031306/11681339/560d7d56-9e84-11e5-9900-ff5c66779d80.png">
<img width="1676" alt="screen shot 2015-12-09 at 2 35 47 pm" src="https://cloud.githubusercontent.com/assets/2031306/11681340/560f93fc-9e84-11e5-9c09-8ae8e91769cd.png">
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/r-kamath/incubator-zeppelin interpreterPropertyPageFix
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/525.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #525
----
commit 146ef212be984b4559b61a9e7b8ba9c5c629b157
Author: Renjith Kamath <re...@gmail.com>
Date: 2015-12-09T09:13:30Z
Interpreter properties editor updates
- Add extra validations in add new interpreter property function to
prevent 'undefined'
- Instead of an empty table show a message when there are no properties to display
- Apply bootstrap style for the table
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-165015122
@corneadoug border-top looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by r-kamath <gi...@git.apache.org>.
Github user r-kamath commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-164673854
@corneadoug thanks for the review. Removed the table header style and other changes in de75e49
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-164967352
By adding this to interpreter.css:
```
table.table-striped {
border-top: 1px solid #ddd;
margin-top: 20px;
}
```
We are making Table Header stand out a bit more, and it looks less crowded
Otherwise LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-164997106
Build fail is not related (random timeout fail), you can just re-trigger CI and it should be green
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-zeppelin/pull/525
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-165033577
Merging If There is no more discussions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by prabhjyotsingh <gi...@git.apache.org>.
Github user prabhjyotsingh commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-165038756
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-zeppelin pull request: Interpreter properties editor upd...
Posted by corneadoug <gi...@git.apache.org>.
Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/525#issuecomment-164642819
I don't like the new table style, because I think that grey background doesn't go well with the rest.
Originally the header of the table component is even supposed to be white. However I like the way it was as a striped row because it is similar to the graph table header background color. To me, having the text in bold is enough to know its a header.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---