You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@arrow.apache.org by "tacaswell (via GitHub)" <gi...@apache.org> on 2024/04/30 19:13:46 UTC
[I] _Py_IsFinalizing will be removed in Python 313 [arrow]
tacaswell opened a new issue, #41475:
URL: https://github.com/apache/arrow/issues/41475
### Describe the bug, including details regarding any error messages, version, and platform.
`_Py_IsFinalizing` was removed in https://github.com/python/cpython/pull/106400 and replaced with a public version in https://github.com/python/cpython/pull/108032 .
This function is used 5 places in `udf.cc` for example: https://github.com/apache/arrow/blob/0ef7351986ee8b967e210d0f9c7a9c8e4d4038fd/python/pyarrow/src/arrow/python/udf.cc#L49-L53 which prevents building on Python 3.13.
Presumably this will need to be version gated on the version of CPython, but I am not sure how you prefer to do that in arrow.
### Component(s)
Python
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@arrow.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python] _Py_IsFinalizing will be removed in Python 313 [arrow]
Posted by "tacaswell (via GitHub)" <gi...@apache.org>.
tacaswell commented on issue #41475:
URL: https://github.com/apache/arrow/issues/41475#issuecomment-2088476819
https://github.com/cython/cython/blob/a6d810b970c21948c7fcdeec2cf28769e716e4a9/Cython/Utility/ModuleSetupCode.c#L671-L703 is an example of how cython does it internally (which is the project where I have seen this done the most at the c level).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [I] [Python] _Py_IsFinalizing will be removed in Python 313 [arrow]
Posted by "jorisvandenbossche (via GitHub)" <gi...@apache.org>.
jorisvandenbossche commented on issue #41475:
URL: https://github.com/apache/arrow/issues/41475#issuecomment-2088107949
Thanks for the heads up! (cc @pitrou)
> Presumably this will need to be version gated on the version of CPython, but I am not sure how you prefer to do that in arrow.
I assume we can use an `#if` / `#else` directive with one of the version macros that CPython exposes (https://docs.python.org/3/c-api/apiabiversion.html).
From a quick look it seems we actually don't yet have any version specific code for CPython.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org