You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by GitBox <gi...@apache.org> on 2020/09/22 20:28:09 UTC

[GitHub] [hbase] gjacoby126 commented on a change in pull request #2440: HBASE-25082: Per table WAL metrics: appendCount and appendSize

gjacoby126 commented on a change in pull request #2440:
URL: https://github.com/apache/hbase/pull/2440#discussion_r493012475



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/MetricsWAL.java
##########
@@ -58,9 +59,10 @@ public void postSync(final long timeInNanos, final int handlerSyncs) {
   @Override
   public void postAppend(final long size, final long time, final WALKey logkey,
       final WALEdit logEdit) throws IOException {
-    source.incrementAppendCount();
+    TableName tableName = logkey.getTableName();

Review comment:
       Is it legal for an implementation to pass in a null WALKey, or a non-null WALKey with a null TableName? (As was done in the prior version of TestMetricsWAL?) If so, we may need some NPE protection. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org