You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by aljoscha <gi...@git.apache.org> on 2016/02/05 14:47:40 UTC

[GitHub] flink pull request: [FLINK-3339] Make ValueState.update(null) act ...

GitHub user aljoscha opened a pull request:

    https://github.com/apache/flink/pull/1594

    [FLINK-3339] Make ValueState.update(null) act as ValueState.clear()

    This was causing problems with TypeSerializers that choke on null
    values, especially in the Scala KeyedStream.*WithState() family of
    functions.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/aljoscha/flink state-fix-null

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/1594.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1594
    
----
commit d3bae5e171cd6a572966022380e30eb6df08108b
Author: Aljoscha Krettek <al...@gmail.com>
Date:   2016-02-05T13:46:14Z

    [FLINK-3339] Make ValueState.update(null) act as ValueState.clear()
    
    This was causing problems with TypeSerializers that choke on null
    values, especially in the Scala KeyedStream.*WithState() family of
    functions.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3339] Make ValueState.update(null) act ...

Posted by mbalassi <gi...@git.apache.org>.

Github user mbalassi commented on the pull request:

    https://github.com/apache/flink/pull/1594#issuecomment-180842858
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3339] Make ValueState.update(null) act ...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha closed the pull request at:

    https://github.com/apache/flink/pull/1594


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] flink pull request: [FLINK-3339] Make ValueState.update(null) act ...

Posted by StephanEwen <gi...@git.apache.org>.

Github user StephanEwen commented on the pull request:

    https://github.com/apache/flink/pull/1594#issuecomment-181069421
  
    +1 to merge this


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---