You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/07 09:39:57 UTC
[GitHub] flink pull request #5420: [FLINK-8576][QS] Reduce verbosity when classes can...
GitHub user zentol opened a pull request:
https://github.com/apache/flink/pull/5420
[FLINK-8576][QS] Reduce verbosity when classes can't be found
This PR reduces the verbosity of DEBUG logging messages when the flink-queryable-state-runtime jar is not on the classpath. Instead of the full stacktrace we now only include the exception message.
I've also modified the message to explicitly mention that this jar is only needed if queryable state is to be used. The previous message made it sound as if this was a critical issue that has to be fixed.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/zentol/flink 8576
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/5420.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #5420
----
commit 0bdb29328324cd8c30418c99ea5e0dd66938487b
Author: zentol <ch...@...>
Date: 2018-02-07T09:31:41Z
[FLINK-8576][QS] Reduce verbosity when classes can't be found
----
---
[GitHub] flink pull request #5420: [FLINK-8576][QS] Reduce verbosity when classes can...
Posted by kl0u <gi...@git.apache.org>.
Github user kl0u commented on a diff in the pull request:
https://github.com/apache/flink/pull/5420#discussion_r168137274
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateUtils.java ---
@@ -132,9 +134,7 @@ public static KvStateServer createKvStateServer(
KvStateRequestStats.class);
return constructor.newInstance(address, ports, eventLoopThreads, queryThreads, kvStateRegistry, stats);
} catch (ClassNotFoundException e) {
- final String msg = "Could not load Queryable State Server. " +
- "Probable reason: flink-queryable-state-runtime is not in the classpath. " +
- "Please put the corresponding jar from the opt to the lib folder.";
+ final String msg = "Could not load Queryable State Server. " + ERROR_MESSAGE_ON_LOAD_FAILURE;
if (LOG.isDebugEnabled()) {
LOG.debug(msg, e);
--- End diff --
The `debug` message should change as well as above, right?
---
[GitHub] flink pull request #5420: [FLINK-8576][QS] Reduce verbosity when classes can...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/5420#discussion_r168138976
--- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/query/QueryableStateUtils.java ---
@@ -132,9 +134,7 @@ public static KvStateServer createKvStateServer(
KvStateRequestStats.class);
return constructor.newInstance(address, ports, eventLoopThreads, queryThreads, kvStateRegistry, stats);
} catch (ClassNotFoundException e) {
- final String msg = "Could not load Queryable State Server. " +
- "Probable reason: flink-queryable-state-runtime is not in the classpath. " +
- "Please put the corresponding jar from the opt to the lib folder.";
+ final String msg = "Could not load Queryable State Server. " + ERROR_MESSAGE_ON_LOAD_FAILURE;
if (LOG.isDebugEnabled()) {
LOG.debug(msg, e);
--- End diff --
ah, of course...
---
[GitHub] flink issue #5420: [FLINK-8576][QS] Reduce verbosity when classes can't be f...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5420
@kl0u Thanks for the pointer, have updated the PR accordingly.
---
[GitHub] flink issue #5420: [FLINK-8576][QS] Reduce verbosity when classes can't be f...
Posted by zentol <gi...@git.apache.org>.
Github user zentol commented on the issue:
https://github.com/apache/flink/pull/5420
merging
---
[GitHub] flink pull request #5420: [FLINK-8576][QS] Reduce verbosity when classes can...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/5420
---