[GitHub] [airflow] ashb commented on a change in pull request #5429: [AIRFLOW-4516] K8s runAsUser and fsGroup cannot be strings

[GitBox <gi...@apache.org>]

ashb commented on a change in pull request #5429: [AIRFLOW-4516] K8s runAsUser and fsGroup cannot be strings
URL: https://github.com/apache/airflow/pull/5429#discussion_r296724571
 
 

 ##########
 File path: airflow/executors/kubernetes_executor.py
 ##########
 @@ -267,6 +267,15 @@ def __init__(self):
             self.kube_client_request_args = {}
         self._validate()
 
+    # pod security context items should return integers
+    # and only return a blank string if contexts are not set.
+    def _get_security_context_val(self, scontext):
+        val = configuration.get(self.kubernetes_section, scontext)
+        if len(val) == 0:
 
 Review comment:
   No, not given that the default config has `run_as_user =` in it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services