You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2018/05/10 22:09:51 UTC

[GitHub] azai91 commented on a change in pull request #10892: [MXNET-412] Loss update performance

azai91 commented on a change in pull request #10892: [MXNET-412] Loss update performance
URL: https://github.com/apache/incubator-mxnet/pull/10892#discussion_r187473856
 
 

 ##########
 File path: python/mxnet/metric.py
 ##########
 @@ -421,8 +421,6 @@ def update(self, labels, preds):
             label = label.flat
             pred_label = pred_label.flat
 
-            labels, preds = check_label_shapes(label, pred_label)
 
 Review comment:
   IDE detected that we were not using the return values. realize now that we are using to check shapes. will just call the function and not store return value.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services