You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2019/05/02 10:22:36 UTC
[GitHub] [cloudstack] anuragaw commented on issue #3293: Limit selecting of
secondary storage with 90% utilization
anuragaw commented on issue #3293: Limit selecting of secondary storage with 90% utilization
URL: https://github.com/apache/cloudstack/pull/3293#issuecomment-488622762
I can suggest doing some more tests with storage to max capacity -
1. Creating snapshots (VM and Storage)
2. Launching VMs
3. Migrating Volumes
The only place I saw where the null check was not carried was in `SecondaryStorageManagerImpl`-
``` @Override
public boolean finalizeVirtualMachineProfile(VirtualMachineProfile profile, DeployDestination dest, ReservationContext context) {
SecondaryStorageVmVO vm = _secStorageVmDao.findById(profile.getId());
Map<String, String> details = _vmDetailsDao.listDetailsKeyPairs(vm.getId());
vm.setDetails(details);
DataStore secStore = _dataStoreMgr.getImageStore(dest.getDataCenter().getId());
assert (secStore != null);```
I hope it helps.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services