[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #5373: minor: make table resolution an independent function ...

["waynexia (via GitHub)" <gi...@apache.org>]

waynexia commented on code in PR #5373:
URL: https://github.com/apache/arrow-datafusion/pull/5373#discussion_r1117039721


##########
datafusion/core/src/execution/context.rs:
##########
@@ -1774,21 +1775,20 @@ impl SessionState {
         Ok(statement)
     }
 
-    /// Convert an AST Statement into a LogicalPlan
-    pub async fn statement_to_plan(
+    /// Resolve all table references in the SQL statement.
+    pub fn resolve_table_references(
         &self,
-        statement: datafusion_sql::parser::Statement,
-    ) -> Result<LogicalPlan> {
+        statement: &datafusion_sql::parser::Statement,

Review Comment:
   This is not brought in this patch, but it would be better if we could import and use `Statement` directly



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org