You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/05/01 12:28:07 UTC
[GitHub] [tvm] tqchen opened a new pull request #7961: [RPC] Make tracker jupyter friendly
tqchen opened a new pull request #7961:
URL: https://github.com/apache/tvm/pull/7961
This PR uses the PopenWorker to handle the tracker start up
and makes the tracker jupyter friendly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 merged pull request #7961: [RPC] Make tracker jupyter friendly via PopenWorker
Posted by GitBox <gi...@apache.org>.
junrushao1994 merged pull request #7961:
URL: https://github.com/apache/tvm/pull/7961
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on pull request #7961: [RPC] Make tracker jupyter friendly via PopenWorker
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on pull request #7961:
URL: https://github.com/apache/tvm/pull/7961#issuecomment-831520300
Thanks Tianqi!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tqchen commented on a change in pull request #7961: [RPC] Make tracker jupyter friendly via PopenWorker
Posted by GitBox <gi...@apache.org>.
tqchen commented on a change in pull request #7961:
URL: https://github.com/apache/tvm/pull/7961#discussion_r625323930
##########
File path: python/tvm/rpc/tracker.py
##########
@@ -427,11 +461,14 @@ def terminate(self):
if self.proc:
if self.proc.is_alive():
self._stop_tracker()
- self.proc.join(1)
+ self.proc.join(0.1)
Review comment:
to make sure the wait time is shorter, since in most cases there are wait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao1994 commented on a change in pull request #7961: [RPC] Make tracker jupyter friendly via PopenWorker
Posted by GitBox <gi...@apache.org>.
junrushao1994 commented on a change in pull request #7961:
URL: https://github.com/apache/tvm/pull/7961#discussion_r625294469
##########
File path: python/tvm/rpc/tracker.py
##########
@@ -427,11 +461,14 @@ def terminate(self):
if self.proc:
if self.proc.is_alive():
self._stop_tracker()
- self.proc.join(1)
+ self.proc.join(0.1)
Review comment:
Just curious, why is it changed to 0.1?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org