You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/07 08:06:10 UTC

[GitHub] [hudi] codope opened a new pull request, #5778: [DOCS] Add externalized confilg file doc in latest versions

codope opened a new pull request, #5778:
URL: https://github.com/apache/hudi/pull/5778

   ## What is the purpose of the pull request
   
   [Externalized config file](https://hudi.apache.org/docs/0.10.0/configurations#externalized-config-file) documentation is missing in 0.10.1 or later versions. Added it in this PR and also added a link to it in the quickstart guide.
   
   ## Brief change log
   
   *(for example:)*
     - *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
   
   ## Verify this pull request
   
   *(Please pick either of the following options)*
   
   This pull request is a trivial rework / code cleanup without any test coverage.
   
   *(or)*
   
   This pull request is already covered by existing tests, such as *(please describe tests)*.
   
   (or)
   
   This change added tests and can be verified as follows:
   
   *(example:)*
   
     - *Added integration tests for end-to-end.*
     - *Added HoodieClientWriteTest to verify the change.*
     - *Manually verified the change by running a job locally.*
   
   ## Committer checklist
   
    - [ ] Has a corresponding JIRA in PR title & commit
    
    - [ ] Commit message is descriptive of the change
    
    - [ ] CI is green
   
    - [ ] Necessary doc changes done or have another open PR
          
    - [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bhasudha commented on pull request #5778: [DOCS] Add externalized confilg file doc in latest versions

Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #5778:
URL: https://github.com/apache/hudi/pull/5778#issuecomment-1150342257

   Thanks for flagging this @codope . I think this PR will temporarily solve the configs but we will see this issue again when next release docs are published because of the way HoodieConfigDocGenerator works. I noticed that this section is not covered in https://github.com/apache/hudi/blob/dbba60ae8c6ec74801262f3a89e58d641f204d16/hudi-utils/src/main/java/org/apache/hudi/utils/HoodieConfigDocGenerator.java#L87 . Write after the summary and table of contents are published the spark configs are handled. We will need another PR to add this to the HoodieConfigDocGenerato class and permanently fix it. Let me send out another PR. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] bhasudha commented on pull request #5778: [DOCS] Add externalized confilg file doc in latest versions

Posted by GitBox <gi...@apache.org>.
bhasudha commented on PR #5778:
URL: https://github.com/apache/hudi/pull/5778#issuecomment-1164994542

   > @bhasudha : do we have a tracking ticket for the follow up work that you mentioned.
   
   This is taken care of in this commit - https://github.com/apache/hudi/commit/799f1f5fea5e90fc8152f3f8bd2654cec59649dd 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan commented on pull request #5778: [DOCS] Add externalized confilg file doc in latest versions

Posted by GitBox <gi...@apache.org>.
nsivabalan commented on PR #5778:
URL: https://github.com/apache/hudi/pull/5778#issuecomment-1164992499

   @bhasudha : do we have a tracking ticket for the follow up work that you mentioned.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [hudi] nsivabalan merged pull request #5778: [DOCS] Add externalized confilg file doc in latest versions

Posted by GitBox <gi...@apache.org>.
nsivabalan merged PR #5778:
URL: https://github.com/apache/hudi/pull/5778


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org