You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/28 11:50:26 UTC
[GitHub] [arrow] alamb commented on a change in pull request #9347: ARROW-11414: [Rust] Reduce copies in Schema::try_merge
alamb commented on a change in pull request #9347:
URL: https://github.com/apache/arrow/pull/9347#discussion_r566032725
##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1836,7 +1836,7 @@ impl Schema {
/// ```
/// use arrow::datatypes::*;
///
- /// let merged = Schema::try_merge(&vec![
+ /// let merged = Schema::try_merge(vec![
Review comment:
this example shows a pretty good example of how I think the usability (as well as performance) of this API is improved by this PR
##########
File path: rust/arrow/src/datatypes.rs
##########
@@ -1836,7 +1836,7 @@ impl Schema {
/// ```
/// use arrow::datatypes::*;
///
- /// let merged = Schema::try_merge(&vec![
+ /// let merged = Schema::try_merge(vec![
Review comment:
The change in this example shows a pretty good example of how I think the usability (as well as performance) of this API is improved by this PR
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org