You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/07/17 09:31:33 UTC

[GitHub] [airflow] BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template

BasPH commented on a change in pull request #5461: [AIRFLOW-4835] Refactor render_template
URL: https://github.com/apache/airflow/pull/5461#discussion_r304306446
 
 

 ##########
 File path: airflow/models/baseoperator.py
 ##########
 @@ -634,45 +634,39 @@ def __setstate__(self, state):
         self.__dict__ = state
         self._log = logging.getLogger("airflow.task.operators")
 
-    def render_template_from_field(self, attr, content, context, jinja_env):
+    def render_template(self, content: Any, context: Dict, jinja_env: jinja2.Environment = None) -> Any:
 
 Review comment:
   Good catch, fixed.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services