You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by "Stanislav Kozlovski (JIRA)" <ji...@apache.org> on 2019/02/07 21:21:00 UTC
[jira] [Updated] (KAFKA-7893) Refactor ConsumerBounceTest.scala

     [ https://issues.apache.org/jira/browse/KAFKA-7893?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Stanislav Kozlovski updated KAFKA-7893:
---------------------------------------
    Description: 
The [ConsumerBounceTest|https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala] has logic to create consumers and ensure that they are in the same consumer group. There is code that already does this in `BaseConsumerTest` and `PlaintextConsumerTest` - it would be better if we could make `ConsumerBounceTest` reuse that functionality.

As part of [https://github.com/apache/kafka/pull/6163,] it is worth investigating if we could assert the newly-introduced test cases there with unit tests as opposed to integration

  was:
The [ConsumerBounceTest|https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala] has logic to create consumers and ensure that they are in the same consumer group. There is code that already does this in `BaseConsumerTest` and `PlaintextConsumerTest` -it would be better if we could make `ConsumerBounceTest` reuse that functionality.

As part of [https://github.com/apache/kafka/pull/6163,] it is worth investigating if we could assert the newly-introduced test cases there with unit tests as opposed to integration


> Refactor ConsumerBounceTest.scala
> ---------------------------------
>
>                 Key: KAFKA-7893
>                 URL: https://issues.apache.org/jira/browse/KAFKA-7893
>             Project: Kafka
>          Issue Type: Improvement
>            Reporter: Stanislav Kozlovski
>            Assignee: Stanislav Kozlovski
>            Priority: Minor
>
> The [ConsumerBounceTest|https://github.com/apache/kafka/blob/trunk/core/src/test/scala/integration/kafka/api/ConsumerBounceTest.scala] has logic to create consumers and ensure that they are in the same consumer group. There is code that already does this in `BaseConsumerTest` and `PlaintextConsumerTest` - it would be better if we could make `ConsumerBounceTest` reuse that functionality.
> As part of [https://github.com/apache/kafka/pull/6163,] it is worth investigating if we could assert the newly-introduced test cases there with unit tests as opposed to integration



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)