You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2019/02/27 21:27:36 UTC
[GitHub] codecov-io edited a comment on issue #6849: Sort Chart Types based
on Usage
codecov-io edited a comment on issue #6849: Sort Chart Types based on Usage
URL: https://github.com/apache/incubator-superset/pull/6849#issuecomment-468037642
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=h1) Report
> Merging [#6849](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/0b1fbf8299891651b45a89c001f2a054190f1f94?src=pr&el=desc) will **increase** coverage by `8.46%`.
> The diff coverage is `91.66%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/6849/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #6849 +/- ##
==========================================
+ Coverage 56.32% 64.78% +8.46%
==========================================
Files 527 421 -106
Lines 23528 20400 -3128
Branches 2781 2251 -530
==========================================
- Hits 13251 13217 -34
+ Misses 9866 7050 -2816
+ Partials 411 133 -278
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...src/explore/components/controls/VizTypeControl.jsx](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL2NvbXBvbmVudHMvY29udHJvbHMvVml6VHlwZUNvbnRyb2wuanN4) | `82.6% <91.66%> (+4.34%)` | :arrow_up: |
| [superset/assets/src/query/index.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9pbmRleC50cw==) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/buildQueryObject.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9idWlsZFF1ZXJ5T2JqZWN0LnRz) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/buildQueryContext.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9idWlsZFF1ZXJ5Q29udGV4dC50cw==) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/Metric.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9NZXRyaWMudHM=) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/FormData.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9Gb3JtRGF0YS50cw==) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/Column.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9Db2x1bW4udHM=) | `0% <0%> (-100%)` | :arrow_down: |
| [superset/assets/src/query/DatasourceKey.ts](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9xdWVyeS9EYXRhc291cmNlS2V5LnRz) | `0% <0%> (-92.31%)` | :arrow_down: |
| [...rset/assets/src/explore/reducers/exploreReducer.js](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9leHBsb3JlL3JlZHVjZXJzL2V4cGxvcmVSZWR1Y2VyLmpz) | `35.71% <0%> (-12.57%)` | :arrow_down: |
| [...erset/assets/src/dashboard/reducers/datasources.js](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL3NyYy9kYXNoYm9hcmQvcmVkdWNlcnMvZGF0YXNvdXJjZXMuanM=) | `57.14% <0%> (-9.53%)` | :arrow_down: |
| ... and [234 more](https://codecov.io/gh/apache/incubator-superset/pull/6849/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=footer). Last update [0b1fbf8...6412e01](https://codecov.io/gh/apache/incubator-superset/pull/6849?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org