You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/03/22 21:55:06 UTC
[GitHub] [superset] yardz opened a new pull request #13736: Tests for DataTablesPane
yardz opened a new pull request #13736:
URL: https://github.com/apache/superset/pull/13736
### SUMMARY
Tests for DataTablesPane component
### TEST PLAN
No behavior changes. All tests must pass.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head d8a2e76. Consider uploading reports for the commit d8a2e76 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/db\_engine\_specs/dremio.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL2RyZW1pby5weQ==) | | |
| [superset/reports/commands/update.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy91cGRhdGUucHk=) | | |
| [superset/translations/utils.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdHJhbnNsYXRpb25zL3V0aWxzLnB5) | | |
| [superset/result\_set.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVzdWx0X3NldC5weQ==) | | |
| [superset/annotation\_layers/annotations/api.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYW5ub3RhdGlvbl9sYXllcnMvYW5ub3RhdGlvbnMvYXBpLnB5) | | |
| [superset/reports/dao.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9kYW8ucHk=) | | |
| [superset/views/dashboard/views.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL3ZpZXdzLnB5) | | |
| [superset/db\_engine\_specs/snowflake.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3Nub3dmbGFrZS5weQ==) | | |
| [superset/utils/core.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY29yZS5weQ==) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...d8a2e76](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r602362379
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
};
return (
- <SouthPane>
+ <SouthPane data-test="DataTablesPane">
Review comment:
Okay, I don't have such a strong opinion. As they are already "2 against" we will keep it that way :-)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] commented on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/sql\_lab.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvc3FsX2xhYi5weQ==) | | |
| [superset/commands/exceptions.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbWFuZHMvZXhjZXB0aW9ucy5weQ==) | | |
| [superset/views/database/validators.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGF0YWJhc2UvdmFsaWRhdG9ycy5weQ==) | | |
| [superset/views/key\_value.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3Mva2V5X3ZhbHVlLnB5) | | |
| [superset/examples/multiformat\_time\_series.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvbXVsdGlmb3JtYXRfdGltZV9zZXJpZXMucHk=) | | |
| [superset/databases/schemas.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL3NjaGVtYXMucHk=) | | |
| [superset/views/core.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | | |
| [superset/models/sql\_types/presto\_sql\_types.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9wcmVzdG9fc3FsX3R5cGVzLnB5) | | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...aa6bacb](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `3.42%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head 6034664. Consider uploading reports for the commit 6034664 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 76.78% 73.35% -3.43%
==========================================
Files 935 620 -315
Lines 47292 21943 -25349
Branches 5895 5818 -77
==========================================
- Hits 36311 16097 -20214
+ Misses 10824 5702 -5122
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+4.21%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.03%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset-frontend/src/explore/index.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvaW5kZXguanN4) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [superset-frontend/src/dashboard/index.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9pbmRleC5qc3g=) | `63.63% <0.00%> (-36.37%)` | :arrow_down: |
| [...-frontend/src/views/CRUD/welcome/ActivityTable.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9BY3Rpdml0eVRhYmxlLnRzeA==) | `72.36% <0.00%> (-12.69%)` | :arrow_down: |
| [...tersConfigModal/FiltersConfigForm/DefaultValue.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL0ZpbHRlcnNDb25maWdGb3JtL0RlZmF1bHRWYWx1ZS50c3g=) | `90.47% <0.00%> (-9.53%)` | :arrow_down: |
| [...src/dashboard/components/gridComponents/Header.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2dyaWRDb21wb25lbnRzL0hlYWRlci5qc3g=) | `97.36% <0.00%> (-2.64%)` | :arrow_down: |
| [superset-frontend/src/chart/chartReducer.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NoYXJ0L2NoYXJ0UmVkdWNlci50cw==) | `64.38% <0.00%> (-1.82%)` | :arrow_down: |
| [superset-frontend/src/views/CRUD/utils.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvdXRpbHMudHN4) | `61.79% <0.00%> (-1.37%)` | :arrow_down: |
| [...frontend/src/views/CRUD/welcome/DashboardTable.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9EYXNoYm9hcmRUYWJsZS50c3g=) | `62.50% <0.00%> (-1.14%)` | :arrow_down: |
| [...set-frontend/src/views/CRUD/welcome/ChartTable.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvd2VsY29tZS9DaGFydFRhYmxlLnRzeA==) | `76.08% <0.00%> (-1.00%)` | :arrow_down: |
| ... and [409 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [9d0bb3a...6034664](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (89668c7) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.80%`.
> The diff coverage is `82.60%`.
> :exclamation: Current head 89668c7 differs from pull request most recent head eb119a0. Consider uploading reports for the commit eb119a0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
+ Coverage 76.78% 77.58% +0.80%
==========================================
Files 935 936 +1
Lines 47292 47372 +80
Branches 5895 5920 +25
==========================================
+ Hits 36311 36755 +444
+ Misses 10824 10472 -352
+ Partials 157 145 -12
```
| Flag | Coverage Δ | |
|---|---|---|
| javascript | `64.06% <75.00%> (+0.35%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...frontend/src/components/Checkbox/CheckboxIcons.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvQ2hlY2tib3gvQ2hlY2tib3hJY29ucy50c3g=) | `85.71% <ø> (ø)` | |
| [superset-frontend/src/components/Icon/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvSWNvbi9pbmRleC50c3g=) | `100.00% <ø> (ø)` | |
| [...ontend/src/components/URLShortLinkButton/index.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvVVJMU2hvcnRMaW5rQnV0dG9uL2luZGV4LmpzeA==) | `100.00% <ø> (ø)` | |
| [...src/dashboard/components/filterscope/treeIcons.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL2ZpbHRlcnNjb3BlL3RyZWVJY29ucy5qc3g=) | `100.00% <ø> (ø)` | |
| [...erset-frontend/src/datasource/DatasourceEditor.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFzb3VyY2UvRGF0YXNvdXJjZUVkaXRvci5qc3g=) | `65.82% <0.00%> (ø)` | |
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `88.88% <ø> (ø)` | |
| [...rontend/src/explore/components/EmbedCodeButton.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FbWJlZENvZGVCdXR0b24uanN4) | `80.76% <ø> (ø)` | |
| [...ore/components/controls/AnnotationLayerControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Bbm5vdGF0aW9uTGF5ZXJDb250cm9sLmpzeA==) | `82.85% <ø> (+17.14%)` | :arrow_up: |
| [...explore/components/controls/ColorPickerControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9Db2xvclBpY2tlckNvbnRyb2wuanN4) | `85.00% <ø> (ø)` | |
| [...plore/components/controls/FilterBoxItemControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9GaWx0ZXJCb3hJdGVtQ29udHJvbC5qc3g=) | `73.58% <ø> (ø)` | |
| ... and [89 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [9d0bb3a...eb119a0](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head 4bf5e73. Consider uploading reports for the commit 4bf5e73 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | | |
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | | |
| [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...4bf5e73](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] michael-s-molina commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
michael-s-molina commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r600477572
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
Review comment:
If the props are not modified, you can change it to a `const` and remove `beforeEach`. If only some are being modified, you can override them inside each test.
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'loading', // "success", "rendered"
+ onCollapseChange: jest.fn(),
+};
+
+beforeEach(() => {
+ defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'rendered',
+ onCollapseChange: jest.fn(),
+ };
+});
+
+test('Rendering DataTablesPane correctly', () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.getByTestId('DataTablesPane')).toBeVisible();
+ expect(screen.getByRole('tablist')).toBeVisible();
+ expect(screen.getByRole('tab', { name: 'right Data' })).toBeVisible();
+ expect(screen.getByRole('img', { name: 'right' })).toBeVisible();
+});
+
+test('Shoud show tabs', async () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.queryByText('View results')).not.toBeInTheDocument();
+ expect(screen.queryByText('View samples')).not.toBeInTheDocument();
+ userEvent.click(await screen.findByText('Data'));
+ expect(screen.queryByText('View results')).toBeVisible();
+ expect(screen.queryByText('View samples')).toBeVisible();
+});
+
+test('Shoud show tabs: View results', async () => {
+ render(<DataTablesPane {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(await screen.findByText('Data'));
+ userEvent.click(await screen.findByText('View results'));
+ expect(screen.queryByText('0 rows retrieved')).toBeVisible();
Review comment:
```suggestion
expect(screen.getByText('0 rows retrieved')).toBeVisible();
```
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'loading', // "success", "rendered"
+ onCollapseChange: jest.fn(),
+};
+
+beforeEach(() => {
+ defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'rendered',
+ onCollapseChange: jest.fn(),
+ };
+});
+
+test('Rendering DataTablesPane correctly', () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.getByTestId('DataTablesPane')).toBeVisible();
+ expect(screen.getByRole('tablist')).toBeVisible();
+ expect(screen.getByRole('tab', { name: 'right Data' })).toBeVisible();
+ expect(screen.getByRole('img', { name: 'right' })).toBeVisible();
+});
+
+test('Shoud show tabs', async () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.queryByText('View results')).not.toBeInTheDocument();
+ expect(screen.queryByText('View samples')).not.toBeInTheDocument();
+ userEvent.click(await screen.findByText('Data'));
+ expect(screen.queryByText('View results')).toBeVisible();
+ expect(screen.queryByText('View samples')).toBeVisible();
Review comment:
```suggestion
expect(screen.getByText('View results')).toBeVisible();
expect(screen.getByText('View samples')).toBeVisible();
```
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'loading', // "success", "rendered"
+ onCollapseChange: jest.fn(),
+};
+
+beforeEach(() => {
+ defaultProps = {
+ queryFormData: {
+ viz_type: 'heatmap',
+ datasource: '34__table',
+ slice_id: 456,
+ url_params: {},
+ time_range_endpoints: ['unknown', 'inclusive'],
+ time_range: 'Last week',
+ all_columns_x: 'source',
+ all_columns_y: 'target',
+ metric: 'sum__value',
+ adhoc_filters: [],
+ row_limit: 10000,
+ linear_color_scheme: 'blue_white_yellow',
+ xscale_interval: null,
+ yscale_interval: null,
+ canvas_image_rendering: 'pixelated',
+ normalize_across: 'heatmap',
+ left_margin: 'auto',
+ bottom_margin: 'auto',
+ y_axis_bounds: [null, null],
+ y_axis_format: 'SMART_NUMBER',
+ show_perc: true,
+ sort_x_axis: 'alpha_asc',
+ sort_y_axis: 'alpha_asc',
+ extra_form_data: {
+ custom_form_data: {},
+ override_form_data: {},
+ append_form_data: {},
+ },
+ },
+ tableSectionHeight: 156.9,
+ chartStatus: 'rendered',
+ onCollapseChange: jest.fn(),
+ };
+});
+
+test('Rendering DataTablesPane correctly', () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.getByTestId('DataTablesPane')).toBeVisible();
+ expect(screen.getByRole('tablist')).toBeVisible();
+ expect(screen.getByRole('tab', { name: 'right Data' })).toBeVisible();
+ expect(screen.getByRole('img', { name: 'right' })).toBeVisible();
+});
+
+test('Shoud show tabs', async () => {
+ render(<DataTablesPane {...defaultProps} />, { useRedux: true });
+ expect(screen.queryByText('View results')).not.toBeInTheDocument();
+ expect(screen.queryByText('View samples')).not.toBeInTheDocument();
+ userEvent.click(await screen.findByText('Data'));
+ expect(screen.queryByText('View results')).toBeVisible();
+ expect(screen.queryByText('View samples')).toBeVisible();
+});
+
+test('Shoud show tabs: View results', async () => {
+ render(<DataTablesPane {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(await screen.findByText('Data'));
+ userEvent.click(await screen.findByText('View results'));
+ expect(screen.queryByText('0 rows retrieved')).toBeVisible();
+});
+
+test('Shoud show tabs: View samples', async () => {
+ render(<DataTablesPane {...defaultProps} />, {
+ useRedux: true,
+ });
+ userEvent.click(await screen.findByText('Data'));
+ expect(screen.queryByText('0 rows retrieved')).not.toBeInTheDocument();
+ await act(async () => {
+ userEvent.click(await screen.findByText('View samples'));
+ });
+ expect(screen.queryByText('0 rows retrieved')).toBeVisible();
Review comment:
```suggestion
expect(screen.getByText('0 rows retrieved')).toBeVisible();
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r600749275
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
};
return (
- <SouthPane>
+ <SouthPane data-test="DataTablesPane">
Review comment:
I agree with you, but I chose to go that way for the same reason here: https://github.com/apache/superset/pull/13638#discussion_r600734118
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (746da27) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.64%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 746da27 differs from pull request most recent head 6034664. Consider uploading reports for the commit 6034664 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
+ Coverage 76.78% 77.42% +0.64%
==========================================
Files 935 936 +1
Lines 47292 47427 +135
Branches 5895 5951 +56
==========================================
+ Hits 36311 36721 +410
+ Misses 10824 10562 -262
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.72%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `57.74% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `24.69% <0.00%> (-38.28%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.75% <0.00%> (-5.22%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `69.81% <0.00%> (+0.62%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `84.49% <0.00%> (+0.77%)` | :arrow_up: |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <0.00%> (+0.90%)` | :arrow_up: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <0.00%> (+1.28%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
| ... and [56 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [9d0bb3a...6034664](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] geido commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
geido commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r600522850
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
};
return (
- <SouthPane>
+ <SouthPane data-test="DataTablesPane">
Review comment:
Super small nit. I think I have seen a pretty adopted convention for the `data-test` to be hyphen separated or just lower case
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r601615965
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
Review comment:
done: https://github.com/apache/superset/pull/13753#discussion_r600862661
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas merged pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
rusackas merged pull request #13736:
URL: https://github.com/apache/superset/pull/13736
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head 80e1c7e. Consider uploading reports for the commit 80e1c7e to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/utils/celery.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvY2VsZXJ5LnB5) | | |
| [superset/views/dashboard/mixin.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvZGFzaGJvYXJkL21peGluLnB5) | | |
| [superset/jinja\_context.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvamluamFfY29udGV4dC5weQ==) | | |
| [superset/tasks/celery\_app.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdGFza3MvY2VsZXJ5X2FwcC5weQ==) | | |
| [superset/db\_engine\_specs/redshift.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGJfZW5naW5lX3NwZWNzL3JlZHNoaWZ0LnB5) | | |
| [superset/viz.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | | |
| [superset/examples/energy.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZW5lcmd5LnB5) | | |
| [superset/datasets/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvaW1wb3J0ZXJzL3YxL3V0aWxzLnB5) | | |
| [superset/examples/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvX19pbml0X18ucHk=) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...80e1c7e](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (746da27) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **increase** coverage by `0.64%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 746da27 differs from pull request most recent head eb119a0. Consider uploading reports for the commit eb119a0 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
+ Coverage 76.78% 77.42% +0.64%
==========================================
Files 935 936 +1
Lines 47292 47427 +135
Branches 5895 5951 +56
==========================================
+ Hits 36311 36721 +410
+ Misses 10824 10562 -262
+ Partials 157 144 -13
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.03% <100.00%> (+3.72%)` | :arrow_up: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `57.74% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...frontend/src/explore/components/DataTablesPane.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS50c3g=) | `24.69% <0.00%> (-38.28%)` | :arrow_down: |
| [...end/src/views/CRUD/data/database/DatabaseModal.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvZGF0YS9kYXRhYmFzZS9EYXRhYmFzZU1vZGFsLnRzeA==) | `71.75% <0.00%> (-5.22%)` | :arrow_down: |
| [superset-frontend/src/explore/exploreUtils.js](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvZXhwbG9yZVV0aWxzLmpz) | `69.81% <0.00%> (+0.62%)` | :arrow_up: |
| [...perset-frontend/src/views/CRUD/chart/ChartList.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL3ZpZXdzL0NSVUQvY2hhcnQvQ2hhcnRMaXN0LnRzeA==) | `84.49% <0.00%> (+0.77%)` | :arrow_up: |
| [.../src/explore/components/ControlPanelsContainer.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9Db250cm9sUGFuZWxzQ29udGFpbmVyLnRzeA==) | `97.27% <0.00%> (+0.90%)` | :arrow_up: |
| [...nts/controls/DateFilterControl/utils/dateParser.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9EYXRlRmlsdGVyQ29udHJvbC91dGlscy9kYXRlUGFyc2VyLnRz) | `93.58% <0.00%> (+1.28%)` | :arrow_up: |
| [...ntend/src/explore/components/ExploreChartPanel.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9FeHBsb3JlQ2hhcnRQYW5lbC5qc3g=) | `82.60% <0.00%> (+1.44%)` | :arrow_up: |
| ... and [56 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [9d0bb3a...eb119a0](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (746da27) into [master](https://codecov.io/gh/apache/superset/commit/9d0bb3a3ba38c2289d77e87dfe572c57c51ef7c7?el=desc) (9d0bb3a) will **decrease** coverage by `0.49%`.
> The diff coverage is `100.00%`.
> :exclamation: Current head 746da27 differs from pull request most recent head 6034664. Consider uploading reports for the commit 6034664 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 76.78% 76.28% -0.50%
==========================================
Files 935 936 +1
Lines 47292 47362 +70
Branches 5895 5908 +13
==========================================
- Hits 36311 36131 -180
- Misses 10824 11065 +241
- Partials 157 166 +9
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `49.53% <100.00%> (-2.77%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `57.74% <ø> (ø)` | |
| [.../src/explore/components/controls/SelectControl.jsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9jb250cm9scy9TZWxlY3RDb250cm9sLmpzeA==) | `93.75% <100.00%> (+4.46%)` | :arrow_up: |
| [...ponents/Select/WindowedSelect/WindowedMenuList.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2NvbXBvbmVudHMvU2VsZWN0L1dpbmRvd2VkU2VsZWN0L1dpbmRvd2VkTWVudUxpc3QudHN4) | `10.71% <0.00%> (-85.72%)` | :arrow_down: |
| [...nd/src/filters/components/Select/transformProps.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvdHJhbnNmb3JtUHJvcHMudHM=) | `0.00% <0.00%> (-81.82%)` | :arrow_down: |
| [...c/filters/components/Select/SelectFilterPlugin.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvU2VsZWN0RmlsdGVyUGx1Z2luLnRzeA==) | `0.00% <0.00%> (-80.96%)` | :arrow_down: |
| [...ontend/src/filters/components/Select/buildQuery.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9TZWxlY3QvYnVpbGRRdWVyeS50cw==) | `0.00% <0.00%> (-77.78%)` | :arrow_down: |
| [superset-frontend/src/filters/components/common.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2ZpbHRlcnMvY29tcG9uZW50cy9jb21tb24udHM=) | `0.00% <0.00%> (-66.67%)` | :arrow_down: |
| [superset-frontend/src/dataMask/reducer.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL3JlZHVjZXIudHM=) | `44.00% <0.00%> (-56.00%)` | :arrow_down: |
| [superset-frontend/src/dataMask/actions.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2RhdGFNYXNrL2FjdGlvbnMudHM=) | `33.33% <0.00%> (-46.67%)` | :arrow_down: |
| [...mponents/nativeFilters/FiltersConfigModal/utils.ts](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2Rhc2hib2FyZC9jb21wb25lbnRzL25hdGl2ZUZpbHRlcnMvRmlsdGVyc0NvbmZpZ01vZGFsL3V0aWxzLnRz) | `34.24% <0.00%> (-46.58%)` | :arrow_down: |
| ... and [85 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [9d0bb3a...6034664](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
rusackas commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r602026370
##########
File path: superset-frontend/src/explore/components/DataTablesPane/index.tsx
##########
@@ -255,7 +255,7 @@ export const DataTablesPane = ({
};
return (
- <SouthPane>
+ <SouthPane data-test="DataTablesPane">
Review comment:
Ahh, this is a little counter to my comment/thought on that thread. In the linked example, the data-test attr uses the compnent name _inside_ the component (at the outer DOM layer), so any instance of the component will have that data-test attr. I'm fine with that.
In this case, this is a _particular, purposeful instance_ of _a_ SouthPane component. In this case, I think we should follow the convention and go with the `data-test="some-purposeful-instance"` convention.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head 129b8ab. Consider uploading reports for the commit 129b8ab to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/queries/filters.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcXVlcmllcy9maWx0ZXJzLnB5) | | |
| [superset/\_\_init\_\_.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvX19pbml0X18ucHk=) | | |
| [superset/models/core.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL2NvcmUucHk=) | | |
| [superset/reports/commands/log\_prune.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9jb21tYW5kcy9sb2dfcHJ1bmUucHk=) | | |
| [superset/common/query\_object.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X29iamVjdC5weQ==) | | |
| [superset/views/annotations.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvYW5ub3RhdGlvbnMucHk=) | | |
| [superset/views/chart/views.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY2hhcnQvdmlld3MucHk=) | | |
| [superset/common/query\_actions.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29tbW9uL3F1ZXJ5X2FjdGlvbnMucHk=) | | |
| [superset/examples/flights.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvZmxpZ2h0cy5weQ==) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...129b8ab](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] yardz commented on a change in pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
yardz commented on a change in pull request #13736:
URL: https://github.com/apache/superset/pull/13736#discussion_r600746025
##########
File path: superset-frontend/src/explore/components/DataTablesPane/DataTablesPane.test.tsx
##########
@@ -0,0 +1,135 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+
+import userEvent from '@testing-library/user-event';
+import React from 'react';
+import { render, screen, act } from 'spec/helpers/testing-library';
+import { DataTablesPane } from '.';
+
+let defaultProps = {
Review comment:
Same reason here: https://github.com/apache/superset/pull/13753#discussion_r600729737
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] codecov[bot] edited a comment on pull request #13736: test: DataTablesPane
Posted by GitBox <gi...@apache.org>.
codecov[bot] edited a comment on pull request #13736:
URL: https://github.com/apache/superset/pull/13736#issuecomment-804431642
# [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=h1) Report
> Merging [#13736](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=desc) (aa6bacb) into [master](https://codecov.io/gh/apache/superset/commit/aa92c1e7eb42eaec1a5269d44b35f538994422b2?el=desc) (aa92c1e) will **decrease** coverage by `4.07%`.
> The diff coverage is `n/a`.
> :exclamation: Current head aa6bacb differs from pull request most recent head d4849c7. Consider uploading reports for the commit d4849c7 to get more accurate results
[](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #13736 +/- ##
==========================================
- Coverage 77.43% 73.35% -4.08%
==========================================
Files 933 620 -313
Lines 47093 21943 -25150
Branches 5818 5818
==========================================
- Hits 36465 16097 -20368
+ Misses 10485 5702 -4783
- Partials 143 144 +1
```
| Flag | Coverage Δ | |
|---|---|---|
| cypress | `56.52% <ø> (+0.01%)` | :arrow_up: |
| hive | `?` | |
| javascript | `63.74% <ø> (+0.34%)` | :arrow_up: |
| mysql | `?` | |
| postgres | `?` | |
| presto | `?` | |
| python | `?` | |
| sqlite | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...nd/src/explore/components/DataTablesPane/index.tsx](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQtZnJvbnRlbmQvc3JjL2V4cGxvcmUvY29tcG9uZW50cy9EYXRhVGFibGVzUGFuZS9pbmRleC50c3g=) | `86.07% <ø> (ø)` | |
| [superset/reports/notifications/email.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvcmVwb3J0cy9ub3RpZmljYXRpb25zL2VtYWlsLnB5) | | |
| [superset/examples/birth\_names.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZXhhbXBsZXMvYmlydGhfbmFtZXMucHk=) | | |
| [superset/legacy.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbGVnYWN5LnB5) | | |
| [superset/databases/dao.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YWJhc2VzL2Rhby5weQ==) | | |
| [superset/charts/commands/importers/v1/utils.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY2hhcnRzL2NvbW1hbmRzL2ltcG9ydGVycy92MS91dGlscy5weQ==) | | |
| [superset/datasets/commands/delete.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvZGF0YXNldHMvY29tbWFuZHMvZGVsZXRlLnB5) | | |
| [superset/utils/pandas\_postprocessing.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdXRpbHMvcGFuZGFzX3Bvc3Rwcm9jZXNzaW5nLnB5) | | |
| [superset/views/log/views.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvbG9nL3ZpZXdzLnB5) | | |
| [superset/models/sql\_types/base.py](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree#diff-c3VwZXJzZXQvbW9kZWxzL3NxbF90eXBlcy9iYXNlLnB5) | | |
| ... and [308 more](https://codecov.io/gh/apache/superset/pull/13736/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=footer). Last update [aa92c1e...d4849c7](https://codecov.io/gh/apache/superset/pull/13736?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org