[GitHub] [airflow] TobKed commented on a change in pull request #11287: Improve handling of job_id in BigQuery operators

[GitBox <gi...@apache.org>]

TobKed commented on a change in pull request #11287:
URL: https://github.com/apache/airflow/pull/11287#discussion_r500037926



##########
File path: airflow/providers/google/cloud/hooks/bigquery.py
##########
@@ -1443,6 +1445,12 @@ def get_job(
         job = client.get_job(job_id=job_id, project=project_id, location=location)
         return job
 
+    @staticmethod
+    def _custom_job_id(configuration: Dict[str, Any]) -> str:
+        hash_base = json.dumps(configuration, sort_keys=True)
+        uniqueness_suffix = hashlib.md5(hash_base.encode()).hexdigest()
+        return f"airflow_{int(time.time())}_{uniqueness_suffix}"

Review comment:
       Is it not safer to use microseconds from epoch than seconds?
   
   ```suggestion
           microseconds_from_epoch = int((datetime.now() - datetime.fromtimestamp(0)) / timedelta(microseconds=1))
           return f"airflow_{microseconds_from_epoch}_{uniqueness_suffix}"
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org