You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maka.apache.org by "liuxiaocs7 (via GitHub)" <gi...@apache.org> on 2026/08/24 21:43:43 UTC

[PR] test(desktop): scope slash menu refresh observer [maka]

liuxiaocs7 opened a new pull request, #3739:
URL: https://github.com/apache/maka/pull/3739

   ## Summary
   
   Scope the slash-command menu refresh regression watcher to the open menu and the original listbox and Skills group nodes. Wait for each session's real invocable-skills projection request before checking that those nodes remain connected, avoiding unrelated overlay removals and fixed timing delays.
   
   Fixes #3727
   
   ## Verification
   
   - Targeted stress run: 20/20 passed
   - Confirmed the test fails with the #2667 regression restored
   - Desktop E2E target and isolated reruns passed
   - Desktop unit: 1458/1458 passed
   - Runtime, Runtime Host, Storage, and Eval suites passed
   - Lint, format, Desktop typecheck, and ASF header checks passed
   
   ## AI use
   
   Select exactly one:
   
   - [ ] No generative tool made a substantive contribution
   - [x] Generative tooling made a substantive contribution
   
   Tool(s) and scope: OpenAI Codex implemented the test synchronization and observer scoping changes, added the E2E-only preload signal, and assisted with verification.
   
   ## Checklist
   
   - [x] Tests cover the change and fail without it
   - [x] Lint, format, typecheck and the affected suites pass locally
   
   Does this PR entail a change in behavior?
   
   - [ ] Yes — described under Summary above
   - [x] No


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] test(desktop): scope slash menu refresh observer [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han closed pull request #3739: test(desktop): scope slash menu refresh observer
URL: https://github.com/apache/maka/pull/3739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] test(desktop): scope slash menu refresh observer [maka]

Posted by "M4n5ter (via GitHub)" <gi...@apache.org>.
M4n5ter merged PR #3739:
URL: https://github.com/apache/maka/pull/3739


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org

Re: [PR] test(desktop): scope slash menu refresh observer [maka]

Posted by "Astro-Han (via GitHub)" <gi...@apache.org>.
Astro-Han commented on PR #3739:
URL: https://github.com/apache/maka/pull/3739#issuecomment-5404086876

   Thanks for the thorough fix! We chose to merge #3737 for this issue — it achieves the same correction (narrowing the observer to close the over-broad window) with zero production surface (1 file, no preload changes), which is minimal for a test-only flake. Your approach with a deterministic `waitForInvocableSkillsCall` is causally stronger, but we preferred to avoid expanding the preload test seam for this flake. Appreciate the effort — closing as superseded by #3737.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@maka.apache.org
For additional commands, e-mail: commits-help@maka.apache.org