You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by "Nashuim (via GitHub)" <gi...@apache.org> on 2024/12/10 11:51:41 UTC
[PR] (iOS) Handle frame origin when status bar isn't overlaying the web view [cordova-plugin-statusbar]
Nashuim opened a new pull request, #278:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/278
### Platforms affected
iOS
### Motivation and Context
Fixes #243
### Description
Frame y origin would be incorrect on iOS phones with floating islands when the statusbar isn't overlaying the web view. This change changes the origin so that it takes the webview's safeAreaTop into account
### Testing
Tested on iOS 17 and iOS 18 on iPhone 14 and simulators
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] Commit is prefixed with `(platform)` if this change only applies to one platform (e.g. `(android)`)
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
- [x] I've updated the documentation if necessary
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Handle frame origin when status bar isn't overlaying the web view [cordova-plugin-statusbar]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub commented on PR #278:
URL: https://github.com/apache/cordova-plugin-statusbar/pull/278#issuecomment-5599957278
Thanks for the PR. I will close this, since the plugin is deprecated since [cordova-ios 8.0.0](https://cordova.apache.org/announcements/2025/11/23/cordova-ios-8.0.0.html) released on 23 Nov 2025 and [cordova-android 15.0.0](https://cordova.apache.org/announcements/2026/03/06/cordova-android-15.0.0.html) released on 06 Mar 2026 and should not be used anymore. Functionality has moved to the platform cores.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
Re: [PR] (iOS) Handle frame origin when status bar isn't overlaying the web view [cordova-plugin-statusbar]
Posted by "GitToTheHub (via GitHub)" <gi...@apache.org>.
GitToTheHub closed pull request #278: (iOS) Handle frame origin when status bar isn't overlaying the web view
URL: https://github.com/apache/cordova-plugin-statusbar/pull/278
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org