[GitHub] szha commented on a change in pull request #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering ops

[GitBox <gi...@apache.org>]

szha commented on a change in pull request #11134: [MXNET-507] Set dtype=int32 for ret_indices in ordering ops
URL: https://github.com/apache/incubator-mxnet/pull/11134#discussion_r199310908
 
 

 ##########
 File path: src/operator/tensor/ordering_op-inl.h
 ##########
 @@ -79,6 +80,16 @@ struct TopKParam : public dmlc::Parameter<TopKParam> {
     DMLC_DECLARE_FIELD(is_ascend).set_default(false)
       .describe("Whether to choose k largest or k smallest elements."
                 " Top K largest elements will be chosen if set to false.");
+    DMLC_DECLARE_FIELD(dtype)
+    .add_enum("uint8", mshadow::kUint8)
+    .add_enum("int32", mshadow::kInt32)
+    .add_enum("float16", mshadow::kFloat16)
 
 Review comment:
   should we remove this option given that it won't be supported?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services