You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2019/09/03 10:39:34 UTC

[GitHub] [airflow] ashb commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports

ashb commented on a change in pull request #5944: [AIRFLOW-5362] Reorder imports
URL: https://github.com/apache/airflow/pull/5944#discussion_r320202786
 
 

 ##########
 File path: setup.py
 ##########
 @@ -268,6 +268,7 @@ def write_version(filename: str = os.path.join(*["airflow", "git_version"])):
     'click==6.7',
     'flake8>=3.6.0',
     'flake8-colors',
+    'flake8-isort',
 
 Review comment:
   > License: GNU General Public License v2 (GPLv2) (GPL version 2)
   
   I can't remember what the outcome was on this for other devel only changes. @mik-laj Do you remember?
   
   (Somewhat annoyingly isort itself is MIT)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services