You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/06/07 15:53:40 UTC

[GitHub] [arrow] pitrou commented on a change in pull request #10467: ARROW-12989: [CI] Avoid aggressive cancellation of the "Dev PR" workflow

pitrou commented on a change in pull request #10467:
URL: https://github.com/apache/arrow/pull/10467#discussion_r646725639



##########
File path: .github/workflows/dev_pr.yml
##########
@@ -28,9 +28,8 @@ on:
       - edited
       - synchronize
 
-concurrency:
-  group: ${{ github.repository }}-${{ github.ref }}-${{ github.workflow }}
-  cancel-in-progress: true
+# NOTE: not using the "cancel-in-progress" feature here as the group key
+# does not have enough information for linking it to a particular PR

Review comment:
       See comment: the current key is adequate for a "push_request" event but not for a "push_request_target" event.
   Example:
   https://github.com/apache/arrow/actions/runs/914966579
   
   Given that "Dev PR" should be a fast workflow, I'm not sure it's worth trying to come up with an alternative.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org